Patched KDE Dolphin with Pixel Scaling https://fiftyfourth.xyz/git/dolphin/atom?h=master 2025-04-07T21:09:00Z 2025-04-07T21:09:00Z Felix Ernst felixernst@kde.org 2025-04-07T21:09:00Z urn:sha1:4102ccb80457eea44ea280f0ace2a419602bc34b This huge commit is a nearly complete rewrite of the Dolphin search code. It implements most of the improved Dolphin search UI/UX as designed and discussed in a collaborative effort by Kristen McWilliam, Jin Liu, Andy Betts, Tagwerk, a few others and me. See https://invent.kde.org/system/dolphin/-/issues/46. # Notable changes - A toggle to change the search tool is provided as most contributors deemed that useful in https://invent.kde.org/system/dolphin/-/merge_requests/642#note_985112. - The default search is changed to filenamesearch for maximum reliability. - Removing all search parameters will take users back to the view state prior to starting a search instead of keeping the search results open. - The UI for choosing file types or modification dates has been made more powerful with more granularity and more options. - Most search parameters can be configured from a popup menu which gives us extra space for extra clarity. - Labels and help buttons as well as hyperlinks to settings makes sure the user always knows why some search parameters are unavailable in some contexts. - Chips show important search parameters while the popup is closed. They allow quickly removing filters. - The titles of the search and the input field placeholder message change to make clear whether file names or file contents are searched. - When the user actively switches the search tool, whether content should be searched, or whether to search everywhere, this is preserved for the initial state of the search bar when the user opens it the next time after restarting Dolphin. # Architecture - The new DolphinQuery class is independent of the UI and contains all search parameters modifiable in Dolphin as easy setters and getters. - DolphinQuery objects are also used to update the states of every component in the search UI. There is now a clear separation of UI and search configuration/DolphinQuery. - DolphinQuery is responsible for exporting to and importing from search URLs. - The search UI always reflects the currently configured DolphinQuery no matter if the user changed the UI to change the DolphinQuery or loaded a DolphinQuery/older search URL which then is reflected in the UI. - I tried to simplify all classes and their interaction between each other as much as possible. - I added some tests BUG: 386754 CCBUG: 435119 CCBUG: 458761 BUG: 446387 BUG: 470136 CCBUG: 471556 CCBUG: 475439 CCBUG: 477969 BUG: 480001 BUG: 483578 BUG: 488047 BUG: 488845 BUG: 500103 FIXED-IN: 25.08 2024-07-08T11:41:56Z Felix Ernst felixernst@kde.org 2024-07-08T11:41:56Z urn:sha1:0d981e7b7df266c867004e23a169ba8cc13c8683 Before this commit pressing the free space button when Filelight is not installed would show a singular action called "Install Filelight to View Disk Usage Statistics…". Pressing this button would open the store page for Filelight. This is an okay user experience, but we can do better. This commit makes it so pressing the free space button when Filelight is not installed shows an attractive UI that makes clear that freeing up disk space can be accomplished nicely by installing Filelight. The "Install Filelight…" button on this UI is connected to PackageKit directly, so we do not need to show a separate store like Discover and instead trigger an installation right then and there. For this, the recently introduced DolphinPackageInstaller KJob is used. Installation progress is reported through the status bar similar to the progress reporting of slowly loading directories or searches. Installation failure or success is ultimately shown within Dolphin as a passive notification above the view. On Microsoft Windows or when PackageKit is not available, the install button will only open a store page for Filelight. CCBUG: 477739 2024-07-04T11:31:29Z Christoph Cullmann christoph@cullmann.io 2024-07-03T16:56:16Z urn:sha1:638a0663a1a79230a870717e37cb48b9cb61062c use KRecentFilesAction like Kate and others to signal used files/dirs could later be used to plug-in a recently used menu, too, if ever wanted avoids that this dependency could be missed and the functionality is not there, too 2024-07-01T12:03:22Z Felix Ernst felixernst@kde.org 2024-07-01T12:03:22Z urn:sha1:92b178b7404b002778d8288353f65e27ee5de5dd This commit adds a guided setup that leads users from a situation in which they try to "sudo dolphin" towards them successfully setting up and using kio-admin. 1. When users enter "sudo dolphin", they are told to start Dolphin by typing "dolphin --sudo" or "dolphin --admin" instead. 2. When Dolphin is started with "--sudo" or "--admin" it checks whether an "admin" protocol is installed. If not, a guided setup leads users towards installing it. 3. After that, Dolphin starts with an installed "admin" protocoll like kio-admin. Now a non-modal information dialog appears that explains how to activate and use kio-admin. 2023-11-30T07:59:04Z Antonio Rojas arojas@archlinux.org 2023-11-30T07:59:04Z urn:sha1:9c313813f58cc43acf973464c338b4de56156f1f 2022-12-30T12:33:01Z Nicolas Fella nicolas.fella@gmx.de 2022-12-14T23:56:11Z urn:sha1:6d21deb6e48627922fb223a4281ade46d6d230ec When one instance of Dolphin activates another it passes a startupId (X11) / activation token (wayland) along. On X11 this is passed using the DESKTOP_STARTUP_ID environment variable. The code tries to read that through KStartupInfo::startupId(). That doesn't work though, since Qt at startup reads the environment variable afterwards. However, it is nice enough to allow us to access it through QX11Info::nextStartupId(). Use that to read the token in the first instance and pass it to the second instance like we do on Wayland The user-facing impact of this is minimal since KStartupInfo::setNewStartupId internally falls back to KWindowSystem::forceActiveWindow when no startupId is passed. 2022-06-15T09:28:42Z Ahmad Samir a.samirh78@gmail.com 2022-06-11T17:16:13Z urn:sha1:28a74d178071c89dbdc53a193c1db68e0d10ddcb This way we get a build time warning if the var isn't defined at all, e.g. a missing check_include_files() CMake call. 2022-06-15T09:27:55Z Ahmad Samir a.samirh78@gmail.com 2022-06-11T17:09:45Z urn:sha1:8a0003bfbcc87068737ab1e2b94ae7b2ba73eca1 2019-03-18T20:18:04Z Elvis Angelaccio elvis.angelaccio@kde.org 2019-01-15T17:47:27Z urn:sha1:5b463d82fed9a443b098888c0aee8a7b3b322666 Summary: This code has been unused since the KF5 port. Reviewers: #dolphin, #plasma Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D18273 2014-06-28T23:35:37Z Christophe Giboudeaux cgiboudeaux@gmx.com 2014-06-28T22:49:11Z urn:sha1:37492b227544bab6c2958c8be84a750d547890ac