Patched KDE Dolphin with Pixel Scaling https://fiftyfourth.xyz/git/dolphin/atom?h=master 2025-02-03T18:23:16Z 2025-02-03T18:23:16Z Christian Schwarz cmrs@cmrs.io 2025-02-03T18:23:16Z urn:sha1:f81d73a7f3a851dc755ef0cd1fd2a2507587a900 BUG: 462899 2023-12-26T16:11:32Z Alexander Lohnau alexander.lohnau@gmx.de 2023-12-26T16:11:32Z urn:sha1:3f92ac800c5e52d0a5622367ff8ffe8cbbdfa184 2023-07-05T20:44:40Z Nicolas Fella nicolas.fella@gmx.de 2023-07-05T20:44:40Z urn:sha1:f510339f033658eae27f8400bf042b78b36f82f2 2023-07-05T07:59:18Z Friedrich W. H. Kossebau kossebau@kde.org 2023-07-04T20:07:48Z urn:sha1:ed2d352c42a6d517d4f29b3582c0e00aa34fe647 * speeds up incremental builds as changes to a header will not always need the full mocs_compilation.cpp for all the target's headers rebuild, while having a moc file sourced into a source file only adds minor extra costs, due to small own code and the used headers usually already covered by the source file, being for the same class/struct * seems to not slow down clean builds, due to empty mocs_compilation.cpp resulting in those quickly processed, while the minor extra cost of the sourced moc files does not outweigh that in summary. Measured times actually improved by some percent points. (ideally CMake would just skip empty mocs_compilation.cpp & its object file one day) * enables compiler to see all methods of a class in same compilation unit to do some sanity checks * potentially more inlining in general, due to more in the compilation unit * allows to keep using more forward declarations in the header, as with the moc code being sourced into the cpp file there definitions can be ensured and often are already for the needs of the normal class methods 2023-05-16T15:11:51Z Jakob Petsovits jpetso@petsovits.com 2023-05-12T22:13:39Z urn:sha1:b5b6762b15564919b32b33cde9961a75a2e3de22 This commit is the result of a three-way diff that combines my own initial patch with related changes from Felix Ernst's MR !545 and further suggestions by Méven Car. Fixes DolphinMainWindowTest::testNewFileMenuEnabled(). Tests are now passing again for my build. "Create New" was broken by commit c64059bd which switched to the new, non-deprecated KNewFileMenu constructor (kio commit 89bc6bad) that doesn't add itself to the passed KActionCollection parameter. After the switch, hamburger menu and context menu was still working as intended but the menu bar was missing the "Create New" menu. This commit adds the addAction("new_menu") call to the File menu setup that would have previously been called by the deprecated KNewFileMenu constructor. The corresponding test can now find the QObject for the menu's named action again, verifying its existence and enabled-ness like it did before. The DolphinNewFileMenu constructor's unused actionCollection parameter serves no use anymore except to confuse people. We replace it with a single QAction* parameter, createDirAction, which gets passed to setNewFolderShortcutAction(). 2 out of 3 constructor call sites have access to this action, while the remaining call site in dolphinmainwindow.cpp must wait until after it has been initialized by DolphinViewActionHandler. In this case, setNewFolderShortcutAction() is still called manually at a later time. 2023-05-12T20:56:36Z Jakob Petsovits jpetso@petsovits.com 2023-05-12T20:56:36Z urn:sha1:1b0caf69a845d0a68c3d8d1a6bdf98568a673501 2023-03-04T23:49:48Z Nicolas Fella nicolas.fella@gmx.de 2022-10-18T20:38:45Z urn:sha1:c64059bd02061968b184c6c8e3d862423afd2547 2023-02-05T05:45:38Z Serg Podtynnyi serg@podtynnyi.com 2023-02-03T17:14:53Z urn:sha1:38c34eeca315c7be58e65d4d3fb72aaf7b866719 2022-08-24T15:00:01Z Kai Uwe Broulik kde@privat.broulik.de 2022-08-24T15:00:01Z urn:sha1:a44830c3a9f954c376d21d4526d94c26d19d010c There's no point telling the user what they just did. After https://invent.kde.org/frameworks/kio/-/commit/f192c133eb01bc8448d5ddd97fe20f8e6dbc467d this error has a text associated with it, so it might show up in the UI. 2020-10-23T18:23:06Z Alexander Lohnau alexander.lohnau@gmx.de 2020-10-23T17:51:33Z urn:sha1:97415729c34851df75c77a67f27d6299c00bfbc4