dolphin/src/dolphinnewfilemenu.h, branch masterPatched KDE Dolphin with Pixel Scaling
https://fiftyfourth.xyz/git/dolphin/atom?h=master2025-02-03T18:23:16Zimplement shortcut action for file creation2025-02-03T18:23:16ZChristian Schwarzcmrs@cmrs.io2025-02-03T18:23:16Zurn:sha1:f81d73a7f3a851dc755ef0cd1fd2a2507587a900
BUG: 462899
Bring back the "Create New" menu in the menu bar2023-05-16T15:11:51ZJakob Petsovitsjpetso@petsovits.com2023-05-12T22:13:39Zurn:sha1:b5b6762b15564919b32b33cde9961a75a2e3de22
This commit is the result of a three-way diff that
combines my own initial patch with related changes from
Felix Ernst's MR !545 and further suggestions by Méven Car.
Fixes DolphinMainWindowTest::testNewFileMenuEnabled().
Tests are now passing again for my build.
"Create New" was broken by commit c64059bd which switched to the
new, non-deprecated KNewFileMenu constructor (kio commit 89bc6bad)
that doesn't add itself to the passed KActionCollection parameter.
After the switch, hamburger menu and context menu was still working
as intended but the menu bar was missing the "Create New" menu.
This commit adds the addAction("new_menu") call to the File menu
setup that would have previously been called by the deprecated
KNewFileMenu constructor. The corresponding test can now find
the QObject for the menu's named action again, verifying its
existence and enabled-ness like it did before.
The DolphinNewFileMenu constructor's unused actionCollection
parameter serves no use anymore except to confuse people.
We replace it with a single QAction* parameter, createDirAction,
which gets passed to setNewFolderShortcutAction().
2 out of 3 constructor call sites have access to this action,
while the remaining call site in dolphinmainwindow.cpp must wait
until after it has been initialized by DolphinViewActionHandler.
In this case, setNewFolderShortcutAction() is still called manually
at a later time.
Add clang-format and format code as in Frameworks2023-02-05T05:45:38ZSerg Podtynnyiserg@podtynnyi.com2023-02-03T17:14:53Zurn:sha1:38c34eeca315c7be58e65d4d3fb72aaf7b866719Build with QT_NO_KEYWORDS2021-02-09T20:39:50ZNicolas Fellanicolas.fella@gmx.de2021-02-08T22:09:59Zurn:sha1:f65b0899c3666561cafac14f67ab0bb8a5bfa00aOutput of licensedigger + manual cleanup afterwards.2020-08-25T17:07:38ZElvis Angelaccioelvis.angelaccio@kde.org2020-08-25T17:07:38Zurn:sha1:954e8c47906c12edaaf6e6aebdd41516eceb0d44
Unfortunately licensedigger does not strip the trailing * characters.
While at it, use a common style for all source files.
Remove unused #include2018-03-04T18:00:47ZRoman Inflianskasinfroma@gmail.com2018-03-04T13:38:16Zurn:sha1:48b58f830a585b773435c9af5ee2fe8f0c7c641d
Summary: I used CLion inspection to hunt all unused #include
Reviewers: #dolphin, elvisangelaccio, markg
Reviewed By: #dolphin, elvisangelaccio, markg
Subscribers: bcooksley, markg, elvisangelaccio, #dolphin
Differential Revision: https://phabricator.kde.org/D10985
Modernize: Use override where possible2017-11-20T22:25:48ZKevin Funkkfunk@kde.org2017-11-20T22:25:06Zurn:sha1:464b13f3828e5cdd03438d0881c3a62c7cda6333
Also use override instead of Q_DECL_OVERRIDE
Move the KVersionControlPlugin2 interface from konqlib to Dolphin and remove the deprecated KVersionControlPlugin interface from konqlib2015-02-25T16:21:10ZEmmanuel Pescostaemmanuelpescosta099@gmail.com2015-02-25T11:12:55Zurn:sha1:25751088c33ce507096a3e25ee1eeaa7de38c76b
REVIEW: 122687
Q_DECL_OVERRIDE2014-11-03T22:52:18ZLukáš Tinkllukas@kde.org2014-11-03T22:52:18Zurn:sha1:037d5db85bb0bd798d40c557d424c5c9b87457a8Replaced all KNewFileMenu usages in DolphinPart by DolphinNewFileMenu.2013-08-28T16:46:45ZEmmanuel Pescostaemmanuelpescosta099@gmail.com2013-08-28T16:46:45Zurn:sha1:a4ef4bbfdebad708e4b3c772c1ce3e236a4da145
Removed all signal-slot-connections related to DolphinNewFileMenu->errorMessage(QString)
in DolphinMainWindow and DolphinContextMenu and replaced it by a better solution.
Now we make use of the already existing DolphinNewFileMenuObserver singleton class to achieve a better
error handling, because every newly created DolphinContextMenu instance registers himself by DolphinNewFileMenuObserver
and we use this to connect the errorMessage(QString) signal of every DolphinContextMenu instance to the errorMessage(QString)
signal of the DolphinNewFileMenuObserver singleton class.
So we need only one connection from DolphinNewFileMenuObserver to DolphinMainWindow (or to DolphinPart) to
collect all error messages thrown by every DolphinNewFileMenu instance.
REVIEW: 112178