Patched KDE Dolphin with Pixel Scaling https://fiftyfourth.xyz/git/dolphin/atom?h=master 2023-07-05T07:59:18Z 2023-07-05T07:59:18Z Friedrich W. H. Kossebau kossebau@kde.org 2023-07-04T20:07:48Z urn:sha1:ed2d352c42a6d517d4f29b3582c0e00aa34fe647 * speeds up incremental builds as changes to a header will not always need the full mocs_compilation.cpp for all the target's headers rebuild, while having a moc file sourced into a source file only adds minor extra costs, due to small own code and the used headers usually already covered by the source file, being for the same class/struct * seems to not slow down clean builds, due to empty mocs_compilation.cpp resulting in those quickly processed, while the minor extra cost of the sourced moc files does not outweigh that in summary. Measured times actually improved by some percent points. (ideally CMake would just skip empty mocs_compilation.cpp & its object file one day) * enables compiler to see all methods of a class in same compilation unit to do some sanity checks * potentially more inlining in general, due to more in the compilation unit * allows to keep using more forward declarations in the header, as with the moc code being sourced into the cpp file there definitions can be ensured and often are already for the needs of the normal class methods 2023-02-05T05:45:38Z Serg Podtynnyi serg@podtynnyi.com 2023-02-03T17:14:53Z urn:sha1:38c34eeca315c7be58e65d4d3fb72aaf7b866719 2020-08-25T17:07:38Z Elvis Angelaccio elvis.angelaccio@kde.org 2020-08-25T17:07:38Z urn:sha1:954e8c47906c12edaaf6e6aebdd41516eceb0d44 Unfortunately licensedigger does not strip the trailing * characters. While at it, use a common style for all source files. 2018-03-04T18:00:47Z Roman Inflianskas infroma@gmail.com 2018-03-04T13:38:16Z urn:sha1:48b58f830a585b773435c9af5ee2fe8f0c7c641d Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985 2017-10-16T17:56:37Z Elvis Angelaccio elvis.angelaccio@kde.org 2017-10-16T17:56:31Z urn:sha1:f20300256b19cb0a700bc6e5536ba9184503d918 Same fix as in D7655, but this time for the MoveToTrash standard action. Differential Revision: https://phabricator.kde.org/D7860 2017-09-17T09:56:42Z Elvis Angelaccio elvis.angelaccio@kde.org 2017-09-17T09:56:42Z urn:sha1:49396318f0f37f913a91bf02484a16e34fec6bf4 2017-09-17T09:06:32Z Elvis Angelaccio elvis.angelaccio@kde.org 2017-09-02T14:28:49Z urn:sha1:cdd002c57cde0480e6e02c7942e9b92af9d0a3e7 After commit 68bb0ec22a the shortcut for the Delete action is not necessarily Shift+Del, but whatever the user set in System Setting. However DolphinRemoveAction assumes/hardcodes Shift+Del, so we should always make sure we have this shortcut around, for consistency. We just need to add it (if necessary) to the list of shortcuts of the action. However: * for the actual Delete action, we need to append it (if we'd prepend it, it would override a custom primary shortcut in the 'Configure Shortcuts' dialog). * for DolphinRemoveAction, we need to prepend it in order to have Shift+Del (rather than the custom primary shortcut) in the context menu. Differential Revision: https://phabricator.kde.org/D7655 2017-09-07T19:31:42Z Elvis Angelaccio elvis.angelaccio@kde.org 2017-08-24T16:33:27Z urn:sha1:2fd85facf85b39f84eeada10bcf80060bb72ab51 QGuiApplication::queryKeyboardModifiers() does not work on Wayland [1]. We don't need it in the first place, since we already know (thanks to the key events) whether Shift has been pressed or released. So we can just pass this information to DolphinRemoveAction::update(). BUG: 354301 [1]: https://bugreports.qt.io/browse/QTBUG-62786 Differential Revision: https://phabricator.kde.org/D7519 2017-08-09T21:15:30Z Elvis Angelaccio elvis.angelaccio@kde.org 2017-08-09T21:15:30Z urn:sha1:d74f62208caf110a501ccc2243ba05eef4df4ae7 This comment (introduced in commit 39f89141b06c) no longer seems to apply, so drop the duplicate translations and just use the default strings from kconfigwidgets. Differential Revision: https://phabricator.kde.org/D6779 2017-07-27T14:15:03Z Elvis Angelaccio elvis.angelaccio@kde.org 2017-07-18T22:00:37Z urn:sha1:4b5ea05b6760e9020ab87f1d90071e1a2a8f9e99 It was introduced in kconfig(widgets) 5.25. Using the standard action results in less code and no need to hardcode the Del shortcut. Test Plan: - Change shortcut in System Settings -> Shortcuts -> Standard Shortcuts - Make sure the new shortcut is used by dolphin. Differential Revision: https://phabricator.kde.org/D6778