Patched KDE Dolphin with Pixel Scaling https://fiftyfourth.xyz/git/dolphin/atom?h=pixelated-scaling-option 2024-10-31T16:28:02Z 2024-10-31T16:28:02Z Felix Ernst felixernst@zohomail.eu 2024-10-28T02:58:45Z urn:sha1:67695c1b01ea241b359e456dad44488e5cd9fdce Pressing Escape on the location bar while in breadcrumb mode has no effect at all. This commit changes this to instead move the focus to the active view. This is more logical because a user pressing escape while having focus on the location bar is no longer interested in interacting and changing the location in the location bar. They most likely want to act on the current location instead. 2024-05-13T11:01:17Z Jin Liu m.liu.jin@gmail.com 2024-05-13T11:01:17Z urn:sha1:046b41666a8ac1cb0f6aaf0daad0361728f3907e 2023-06-04T16:09:42Z Felix Ernst felixernst@zohomail.eu 2023-06-04T16:09:42Z urn:sha1:e5abe2c67bed7f1ca448cc94eb3abcfbe7d0da92 GIT_SILENT NO_CHANGELOG 2021-10-25T11:34:22Z Laurent Montel montel@kde.org 2021-10-25T11:34:22Z urn:sha1:3f76d92402a9ef982a3da082bec50523e90e8f80 2021-02-09T20:39:50Z Nicolas Fella nicolas.fella@gmx.de 2021-02-08T22:09:59Z urn:sha1:f65b0899c3666561cafac14f67ab0bb8a5bfa00a 2020-12-27T17:38:55Z Nate Graham nate@kde.org 2020-12-10T22:16:12Z urn:sha1:b14f98de19b97bcf8ca967f635c6df39963df2b0 Right now it is not super obvious how you connect to a remote server in Dolphin when you already know the URL. Users will go to the "Network" item in the Places panel, but from there it is not totally clear. The "Add Network Folder" icon in the view opens a complicated wizard and it's also a bit of an odd UX to have it living in the view as opposed to being a toolbar button. Old hands and developers know that the URL navigator is, well, a URL navigator, and as such, it accepts arbitrary URLs from any view. However this may not be obvious to other more casual users, for two reasons: 1. The URL navigator is in breadcrumbs view nearly all of the time and by default, so may users may not know that it can accept text at all 2. Even when it's displaying URLs, they are almost always local paths, so users may not make the connection that it can accept remote URLs rather that just local paths To improve the discoverability of this feature, this commit makes the following change: When the view is displaying the remote:/ ioslave (i.e. the "Networks" place), the URL navigator is put into URL entry mode and given some placeholder text that hints at what it can do. It reverts to breadcrumbs mode when you leave. BUG: 414670 FIXED-IN: 21.04 2020-11-09T22:49:07Z Felix Ernst fe.a.ernst@gmail.com 2020-11-09T13:25:15Z urn:sha1:63f4981fe01d88b2ef1b27e0577d7f5d4c8cc485 Additionally remove some redundant code concerning UrlNavigator visuals. 2020-11-09T22:49:07Z Felix Ernst fe.a.ernst@gmail.com 2020-11-05T22:30:07Z urn:sha1:2d4d2ce9a14902ee5a2b236f8510596fc2f86b99 This commit applies most suggestions which were made on the MR. Most notably the DolphinUrlNavigator class is split up which leads to the creation of a DolphinUrlNavigatorsController class. Additionally some minor coding style and const correctness changes are included. The error value of cached integers is changed from -1 to INT_MIN because situations could come up in which -1 would be a valid value. 2020-11-09T22:49:07Z Felix Ernst fe.a.ernst@gmail.com 2020-09-20T16:53:59Z urn:sha1:37327c9b0aae112c5890703cba1f0157043007e0 The UrlNavigators will be automatically added to the toolbar. The Sort By action is removed from the default toolbar to make space. Remove all options to have UrlNavigators outside the toolbar and remove those code paths. Make it so the new NavigatorsWidgetAction contains two UrlNavigators when in split view mode. Spacing was also added to align these UrlNavigators with the ViewContainers when enough space is available. Force the toolbar to be either at the top or bottom of the window. Set a sane sizeHint for DolphinUrlNavigator. It would be better to do this in KUrlNavigator in the future. This commit also contains a changes which should be moved to a separate merge requests before this gets merged: - Add an expansion animation when split view is enabled by the user 2020-11-09T22:49:07Z Felix Ernst fe.a.ernst@gmail.com 2020-06-14T14:20:02Z urn:sha1:ad5d3367c7fef4c3c11188a768f21a2ee2b3c025 This commit adds a locationInToolbar KToggleAction to switch between using a location bar to navigate or using a new custom QWidgetAction in the toolbar. A big portion of this MR is refactoring because until now the UrlNavigator was tightly intertwined with the DolphinViewContainer. With this MR an UrlNavigator for controlling a View can be freely connected or disconnected with a single method call. A DolphinUrlNavigator class is created in the process which contains all Dolphin-specific UrlNavigator code which did previously reside in the DolphinViewContainer class. Other application parts that belong to UrlNavigator-management are also moved here.