dolphin/src/dolphinurlnavigatorscontroller.cpp, branch pixelated-scaling-optionPatched KDE Dolphin with Pixel Scaling
https://fiftyfourth.xyz/git/dolphin/atom?h=pixelated-scaling-option2023-07-05T07:59:18ZAdd explicit moc includes to sources for moc-covered headers2023-07-05T07:59:18ZFriedrich W. H. Kossebaukossebau@kde.org2023-07-04T20:07:48Zurn:sha1:ed2d352c42a6d517d4f29b3582c0e00aa34fe647
* speeds up incremental builds as changes to a header will not always
need the full mocs_compilation.cpp for all the target's headers rebuild,
while having a moc file sourced into a source file only adds minor
extra costs, due to small own code and the used headers usually
already covered by the source file, being for the same class/struct
* seems to not slow down clean builds, due to empty mocs_compilation.cpp
resulting in those quickly processed, while the minor extra cost of the
sourced moc files does not outweigh that in summary.
Measured times actually improved by some percent points.
(ideally CMake would just skip empty mocs_compilation.cpp & its object
file one day)
* enables compiler to see all methods of a class in same compilation unit
to do some sanity checks
* potentially more inlining in general, due to more in the compilation unit
* allows to keep using more forward declarations in the header, as with the
moc code being sourced into the cpp file there definitions can be ensured
and often are already for the needs of the normal class methods
Update my eMail to the KDE-provided one2023-06-04T16:09:42ZFelix Ernstfelixernst@zohomail.eu2023-06-04T16:09:42Zurn:sha1:e5abe2c67bed7f1ca448cc94eb3abcfbe7d0da92
GIT_SILENT
NO_CHANGELOG
Add clang-format and format code as in Frameworks2023-02-05T05:45:38ZSerg Podtynnyiserg@podtynnyi.com2023-02-03T17:14:53Zurn:sha1:38c34eeca315c7be58e65d4d3fb72aaf7b866719Adress the third round of Angelaccio's review comments2020-11-09T22:49:07ZFelix Ernstfe.a.ernst@gmail.com2020-11-09T13:25:15Zurn:sha1:63f4981fe01d88b2ef1b27e0577d7f5d4c8cc485
Additionally remove some redundant code concerning UrlNavigator visuals.
Adress most of the second round of Angelaccio's review comments2020-11-09T22:49:07ZFelix Ernstfe.a.ernst@gmail.com2020-11-05T22:30:07Zurn:sha1:2d4d2ce9a14902ee5a2b236f8510596fc2f86b99
This commit applies most suggestions which were made on the MR.
Most notably the DolphinUrlNavigator class is split up which leads to
the creation of a DolphinUrlNavigatorsController class.
Additionally some minor coding style and const correctness changes are
included.
The error value of cached integers is changed from -1 to INT_MIN
because situations could come up in which -1 would be a valid value.