Patched KDE Dolphin with Pixel Scaling https://fiftyfourth.xyz/git/dolphin/atom?h=pixelated-scaling-option 2024-10-28T13:25:10Z 2024-10-28T13:25:10Z Felix Ernst felixernst@kde.org 2024-10-28T13:25:10Z urn:sha1:f208acd5f68c8516b9f6a920cc229803637e23e9 This commit brings the main view of Dolphin into a usable state accessibility-wise. Users of screen readers should have a way better experience while browsing files and folders and navigating along the file system hierarchy. This commit fixes most of the remaining already-identified accessibility issues listed in https://invent.kde.org/teams/accessibility/collaboration/-/issues/28, but not all. Namely, these should now be fixed: 1. Orca should read the element type in dolphin (file, folder, device, link to folder, link to file) 2. Orca should read complete label in icon and compact view mode, currently it only speaks the name, but there could be additional information like the number of elements or the file size. 3. Orca is not able to announce Selecting / Unselecting files in Dolphin. It also never announces how many items are selected in total. (Announcing the total selection can be done by reading out the view element or by pressing the Tab key to get to the status bar with the relevant information.) 4. Dolphin opens on the home directory, but Orca doesn't tell you so. Consider enclosing the area in a frame/panel which updates its accessible name each time you modify the current path by entering or leaving a directory. 5. I don't know what the folder presentation widget is, but it should be presented as a grid view. Currently, we have a terrible experience because the entire row of folders is read at once, with no indication that we can move left and right with the arrows to go between the elements of a row. When I found that out, however, I discovered that when you're on the last icon of the first row and press right arrow, you get to the first icon of the next row, but that's not announced, instead, the whole row is announced at once 6. Orca should announce the current elements instead of "layered pane" when the Folder / File view gets the focus in dolphin 7. Orca reads only name in Table View only of Dolphin 8. Items are sometimes confusingly announced as "collapsed" in contexts in which there is no concept of collapsing/expanding e.g. in icon view mode. A lot of code was moved around and renamed. The three accessibility classes, which all used to be in the same file, are moved into separate files. *Acknowledgement* Thanks to Christian Hempfling and bgt lover for testing as well as originally identifying a lot of the pain points being addressed here. This work is part of a my project funded through the NGI0 Entrust Fund, a fund established by NLnet with financial support from the European Commission's Next Generation Internet programme, under the aegis of DG Communications Networks, Content and Technology. https://kde.org/announcements/2024_ngi_openletter/ 2024-08-13T16:09:10Z Yifan Zhu fanzhuyifan@gmail.com 2024-08-09T03:21:08Z urn:sha1:021365dceb590a14bfcdb904ea05ffdd69b7d663 Previously during rename, the number of QChar is used for selection, which might be different from number of unicode characters. Test plan: - create the file zz❤️❤️.txt - rename the file - verify that the first 4 characters are correctly selected, which didn't work before the patch. BUG: 466814 2024-02-18T15:14:58Z Felix Ernst felixernst@zohomail.eu 2024-02-18T10:40:25Z urn:sha1:803a1b36dbb47342be6ca1dfa0b1e65baff74dbb 2023-09-02T12:42:54Z Méven Car meven@kde.org 2023-09-02T09:30:25Z urn:sha1:fae5fec96454fbc848f5402b1d1d758bd7ff2d8d 2023-02-05T05:45:38Z Serg Podtynnyi serg@podtynnyi.com 2023-02-03T17:14:53Z urn:sha1:38c34eeca315c7be58e65d4d3fb72aaf7b866719 2021-07-04T10:24:07Z David Lerch alemariusnexus@gmail.com 2021-01-30T11:11:22Z urn:sha1:aba4462e0238d6075e8822d56a78372eacfa7d2e This shows a slideshow of thumbs when the user hovers a file item. 2020-08-25T17:07:38Z Elvis Angelaccio elvis.angelaccio@kde.org 2020-08-25T17:07:38Z urn:sha1:954e8c47906c12edaaf6e6aebdd41516eceb0d44 Unfortunately licensedigger does not strip the trailing * characters. While at it, use a common style for all source files. 2018-03-04T18:00:47Z Roman Inflianskas infroma@gmail.com 2018-03-04T13:38:16Z urn:sha1:48b58f830a585b773435c9af5ee2fe8f0c7c641d Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985 2017-11-20T22:25:48Z Kevin Funk kfunk@kde.org 2017-11-20T22:25:06Z urn:sha1:464b13f3828e5cdd03438d0881c3a62c7cda6333 Also use override instead of Q_DECL_OVERRIDE 2015-02-25T16:21:10Z Emmanuel Pescosta emmanuelpescosta099@gmail.com 2015-02-25T11:12:55Z urn:sha1:25751088c33ce507096a3e25ee1eeaa7de38c76b REVIEW: 122687