dolphin/src/kitemviews/kitemlistselectionmanager.cpp, branch masterPatched KDE Dolphin with Pixel Scaling
https://fiftyfourth.xyz/git/dolphin/atom?h=master2026-01-22T15:14:16Zclang-tidy: use default for trivial constructor2026-01-22T15:14:16ZMéven Carmeven@kde.org2026-01-22T15:04:09Zurn:sha1:174bc684603326de15e933b3bb24ffb739f3291eAdd explicit moc includes to sources for moc-covered headers2023-07-05T07:59:18ZFriedrich W. H. Kossebaukossebau@kde.org2023-07-04T20:07:48Zurn:sha1:ed2d352c42a6d517d4f29b3582c0e00aa34fe647
* speeds up incremental builds as changes to a header will not always
need the full mocs_compilation.cpp for all the target's headers rebuild,
while having a moc file sourced into a source file only adds minor
extra costs, due to small own code and the used headers usually
already covered by the source file, being for the same class/struct
* seems to not slow down clean builds, due to empty mocs_compilation.cpp
resulting in those quickly processed, while the minor extra cost of the
sourced moc files does not outweigh that in summary.
Measured times actually improved by some percent points.
(ideally CMake would just skip empty mocs_compilation.cpp & its object
file one day)
* enables compiler to see all methods of a class in same compilation unit
to do some sanity checks
* potentially more inlining in general, due to more in the compilation unit
* allows to keep using more forward declarations in the header, as with the
moc code being sourced into the cpp file there definitions can be ensured
and often are already for the needs of the normal class methods
Add clang-format and format code as in Frameworks2023-02-05T05:45:38ZSerg Podtynnyiserg@podtynnyi.com2023-02-03T17:14:53Zurn:sha1:38c34eeca315c7be58e65d4d3fb72aaf7b866719Compile with QT_NO_KEYWORDS2020-10-23T18:23:06ZAlexander Lohnaualexander.lohnau@gmx.de2020-10-23T17:51:33Zurn:sha1:97415729c34851df75c77a67f27d6299c00bfbc4Compile without foreach2020-10-23T18:23:06ZAlexander Lohnaualexander.lohnau@gmx.de2020-10-23T17:48:22Zurn:sha1:a24327cd50ef17b953ecb908d260b73460158107Output of licensedigger + manual cleanup afterwards.2020-08-25T17:07:38ZElvis Angelaccioelvis.angelaccio@kde.org2020-08-25T17:07:38Zurn:sha1:954e8c47906c12edaaf6e6aebdd41516eceb0d44
Unfortunately licensedigger does not strip the trailing * characters.
While at it, use a common style for all source files.
Use URLs with transport encryption2019-11-16T16:53:28ZYuri Chornoivanyurchor@ukr.net2019-11-16T16:53:28Zurn:sha1:808339bff654785d564d6c7d077062f6c649ff77Avoid emitting twice twice selectionChanged when keyboard changes the selection, fix slotChangeCurrentItem2019-10-20T14:05:19ZMéven Carmeven29@gmail.com2019-10-20T10:35:52Zurn:sha1:56a38da57a020ed5617d5293013c4f8cc2d04fc3
Summary:
In KItemListController::slotChangeCurrentItem searchFromNextItem use was bugged :
The two branches of `if (searchFromNextItem)` both looked for the next keyboard with indexForKeyboardSearch(text, currentIndex (the first one with just a +1 modulo).
But when searchFromNextItem is false, we are supposed to start to look for the next indexKeyboard from the start of the list `0`, not from the `currentIndex`
Reviewers: elvisangelaccio, #dolphin
Reviewed By: elvisangelaccio, #dolphin
Subscribers: kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D24505
Fix selection when navigating back, with size sorting.2018-12-01T20:18:58ZThomas Surrelthomas.surrel@protonmail.com2018-11-20T11:10:15Zurn:sha1:6100f66ae2ba5ae50c2fcc263b6faaa695d37948
Summary:
KItemListSelectionManager::itemsMoved (called when sorting by size)
was re-activating anchor selection regardless if we actually were
doing an anchored selection. This was leading to an incorrect
selection when navigating back.
BUG: 352296
Test Plan:
In any folder, sort by size then move to a subfolder. Navigate back
to the parent folder: only the parent folder should be selected.
Reviewers: #dolphin, elvisangelaccio
Reviewed By: #dolphin, elvisangelaccio
Subscribers: elvisangelaccio, broulik, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D17042
use the same bound check as setCurrentItem when setting m_currentItem manually2018-04-08T09:44:26ZFabian Kosmale0inkane@gmail.com2018-04-06T15:57:38Zurn:sha1:3a028d9db0ee4cdd9103d9ab375f95d985539fd2
Summary:
This patch basically adds the check that would normally be done to the
itemInserted method, which seems to be good idea in general.
However, the fact that this is needed there might be an indicator of a logic bug
in the function – though, as I'm not familiar with the code base I cannot judge
this.
Test Plan:
Without this patch, dolphin when started from a terminal prints the following
warning (number can be different):
qt.accessibility.core: Cannot create accessible child interface for object: PlacesView(0x563e863e35c0) index: 10
After applying the patch, the warning doesn't appear anymore. Dolphin still
works still as it did before.
Reviewers: elvisangelaccio, #dolphin
Reviewed By: elvisangelaccio
Subscribers: #dolphin
Differential Revision: https://phabricator.kde.org/D11990