Patched KDE Dolphin with Pixel Scaling https://fiftyfourth.xyz/git/dolphin/atom?h=master 2024-10-28T13:25:10Z 2024-10-28T13:25:10Z Felix Ernst felixernst@kde.org 2024-10-28T13:25:10Z urn:sha1:f208acd5f68c8516b9f6a920cc229803637e23e9 This commit brings the main view of Dolphin into a usable state accessibility-wise. Users of screen readers should have a way better experience while browsing files and folders and navigating along the file system hierarchy. This commit fixes most of the remaining already-identified accessibility issues listed in https://invent.kde.org/teams/accessibility/collaboration/-/issues/28, but not all. Namely, these should now be fixed: 1. Orca should read the element type in dolphin (file, folder, device, link to folder, link to file) 2. Orca should read complete label in icon and compact view mode, currently it only speaks the name, but there could be additional information like the number of elements or the file size. 3. Orca is not able to announce Selecting / Unselecting files in Dolphin. It also never announces how many items are selected in total. (Announcing the total selection can be done by reading out the view element or by pressing the Tab key to get to the status bar with the relevant information.) 4. Dolphin opens on the home directory, but Orca doesn't tell you so. Consider enclosing the area in a frame/panel which updates its accessible name each time you modify the current path by entering or leaving a directory. 5. I don't know what the folder presentation widget is, but it should be presented as a grid view. Currently, we have a terrible experience because the entire row of folders is read at once, with no indication that we can move left and right with the arrows to go between the elements of a row. When I found that out, however, I discovered that when you're on the last icon of the first row and press right arrow, you get to the first icon of the next row, but that's not announced, instead, the whole row is announced at once 6. Orca should announce the current elements instead of "layered pane" when the Folder / File view gets the focus in dolphin 7. Orca reads only name in Table View only of Dolphin 8. Items are sometimes confusingly announced as "collapsed" in contexts in which there is no concept of collapsing/expanding e.g. in icon view mode. A lot of code was moved around and renamed. The three accessibility classes, which all used to be in the same file, are moved into separate files. *Acknowledgement* Thanks to Christian Hempfling and bgt lover for testing as well as originally identifying a lot of the pain points being addressed here. This work is part of a my project funded through the NGI0 Entrust Fund, a fund established by NLnet with financial support from the European Commission's Next Generation Internet programme, under the aegis of DG Communications Networks, Content and Technology. https://kde.org/announcements/2024_ngi_openletter/ 2023-10-05T15:15:35Z Nate Graham nate@kde.org 2023-10-05T15:15:35Z urn:sha1:30a807e44afb334dd153c8bcbdbde4f36942bee0 2023-10-05T12:09:25Z Felix Ernst felixernst@zohomail.eu 2023-07-17T14:13:51Z urn:sha1:549fad2daeeccac53b88b4777dcc9effbc2110e5 Before this commit, KItemListViewAccessible would always return nullptr as its parent. This meant that accessibility software would have to guess to which window/hierarchy the KItemListView belongs to. Guessing shouldn't be necessary here. This commit makes sure that the KItemListView always returns a sensible parent in the accessible hierarchy. It does so by explicitly setting the accessible parent for every KItemListView after construction in the DolphinView contructor. Since KItemListView now always knows about its accessible parent, the accessibleInterfaceFactory can always ask the KItemListView for that information when constructing the QAccessibleInterfaces. Fixes https://invent.kde.org/system/dolphin/-/issues/47. 2023-09-10T13:19:13Z Méven Car meven@kde.org 2023-09-10T13:19:13Z urn:sha1:b58a346be96f7d0973ed96e52c4cf95463ba244d 2023-02-05T05:45:38Z Serg Podtynnyi serg@podtynnyi.com 2023-02-03T17:14:53Z urn:sha1:38c34eeca315c7be58e65d4d3fb72aaf7b866719 2021-12-28T14:48:28Z Fushan Wen qydwhotmail@gmail.com 2021-12-27T16:51:10Z urn:sha1:eb0a7da653493db272ee6039d5202c5702acffc3 Use `value_or(-1)` for those functions that don't use `std::optional`. 2020-10-23T18:23:06Z Alexander Lohnau alexander.lohnau@gmx.de 2020-10-23T17:48:22Z urn:sha1:a24327cd50ef17b953ecb908d260b73460158107 2020-08-25T17:07:38Z Elvis Angelaccio elvis.angelaccio@kde.org 2020-08-25T17:07:38Z urn:sha1:954e8c47906c12edaaf6e6aebdd41516eceb0d44 Unfortunately licensedigger does not strip the trailing * characters. While at it, use a common style for all source files. 2019-11-09T21:09:16Z Elvis Angelaccio elvis.angelaccio@kde.org 2019-11-09T21:06:39Z urn:sha1:16a3aea6a629a91aab937be5c111b64b3ed6cf86 GIT_SILENT 2019-02-18T07:58:11Z David Hallas david@davidhallas.dk 2019-02-16T15:50:42Z urn:sha1:c72fdaa77380ef811dfef626a4edadbb824ed252 Summary: Fix crash during shutdown. The root cause is that when Dolphin in stopped as part of an activity, the KItemListViewAccessible destructor is called after QApplication::exec has returned causing Qt to already having cleaned up the QAccessibleInterface instances kept in KItemListViewAccessible. Instead of storing the pointers to QAccessibleInterface we store the QAccessible::Id so that we can use the QAccessible::deleteAccessibleInterface function for deleting the instances. BUG: 402784 Test Plan: I wasn't able to reproduce the crash in the first place, but I have just opened and closed Dolphin a few times and verified the the QAccessibleInterface instances are correctly cleaned up. Reviewers: #dolphin, elvisangelaccio, ngraham Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19083