dolphin/src/kitemviews/private/kfileitemmodelsortalgorithm.h, branch master

Add clang-format and format code as in Frameworks

2023-02-05T05:45:38Z

Replace qswap with std::swap

2023-01-16T16:45:56Z

Fixes obsolete function 'qSwap' called. It is recommended to use 'std::swap' instead. (CWE-477)

Output of licensedigger + manual cleanup afterwards.

2020-08-25T17:07:38Z

Unfortunately licensedigger does not strip the trailing * characters. While at it, use a common style for all source files.

Fix all krazy #include warnings

2018-02-04T10:38:50Z

- "include own header first line" - "put config.h in angle brackets line" - "do not include QtModule/QtClass line" `QElapsedTimer` was implicitly included by kfileitemmodelsortalgorithm.h, now we need to explicitly include it in kfileitemmodel.cpp. We also need to explicitly link to `Qt5::Concurrent`, otherwise we cannot `#include `.

Fix KFileItemModel performance regression

2015-05-07T20:14:00Z

Commit 119f7a3f fixed a crash that was caused by the porting of the natural sorting code to QCollator. QCollator is not thread-safe, so every thread needs its own instance. However, that commit made every recursive call in the sorting code create a new deep-copied QCollator instance, which is quite expensive and thus made inserting any items into the model very slow (this could also be seen in the KFileItemModel benchmark). This commit avoids unnecessary QCollator copying by forcing all sorting functions which are called in the same thread to pass the 'lessThan' object by const reference, such that no unnecessary copying of that object, including a deep copy of the QCollator, takes place. REVIEW: 123620

Fix includes

2015-02-06T08:35:26Z

Allow compiling Dolphin with KF5

2014-05-05T21:05:13Z

This does not work properly yet, there are probably quite a few bad signal/ slot connections due to KUrl -> QUrl. However dolphin starts without crashing. Accessibility is not ported since that changed quite a lot from Qt4 -> Qt5 and I have no idea how it is supposed to be used. This is the first commit for review 117395

Remove incorrect comments about the sorting functions

2013-01-15T18:07:36Z

In fact, we could use the sorting functions provided by Qt or the STL. The reason why we have our own is that we want to support parallel sorting because sorting many items naturally by name can be expensive.

Re-organise the sorting code

2013-01-15T17:50:37Z

The KFileItemModel-specific parts are now separated from the generic ones, like the parallel sorting implementation. REVIEW: 108386

Change the sort and merge functions to a more generic form.

2013-01-15T17:47:51Z

This might make it easier to reuse the parallel sorting code. Moreover, some the upperBound/lowerBound functions have been removed because equivalents are provided by the STL.