dolphin/src/kitemviews, branch masterPatched KDE Dolphin with Pixel Scalinghttps://fiftyfourth.xyz/git/dolphin/atom/src/kitemviews?h=master2026-06-25T19:09:01Zkfileitemmodel: Avoid zero-as-null-pointer-constant warnings in natural sort2026-06-25T19:09:01ZMéven Carmeven@kde.org2026-06-25T19:08:18Zurn:sha1:50c8b5a3eefcb95c4c0a07c454311ad650f0b5ae
The natural sort comparison helpers compare Qt::strong_ordering values
against the literal 0. The compiler reads that 0 as a null pointer
constant and warns under -Wzero-as-null-pointer-constant.
Use the named ordering helpers is_lt, is_gt and is_neq instead, which
express the same checks without a literal 0. The plain integer
comparisons in the surrounding code are left as they are.
Replace the itemsChanged disconnect/connect dance with a guard2026-06-14T06:56:21ZMéven Carmeven@kde.org2026-06-13T16:11:44Zurn:sha1:451ae420c8454c3f6a157019646781fa97af3b2e
The updater must not react to its own setData() changes, or it would
resolve the roles again. Instead of disconnecting slotItemsChanged()
around every setData() and reconnecting (a dozen times), add a
setModelData() helper that sets a guard while calling setData(), and
make slotItemsChanged() return early while it is set. The view still
gets itemsChanged and repaints.
This also drops a stray disconnect of itemsMoved (never reconnected)
that a hover-sequence block did while duplicating the itemsChanged
connection.
smoothscroller: always emit scrollingStopped from scrollTo2026-06-13T15:26:22ZMéven Carmeven@kde.org2026-06-13T15:24:49Zurn:sha1:5ccdce11680528d1e993bffe2cae8417b5aba8c8
When scrollTo() is asked to move to the position the scrollbar already
holds (clamped, e.g. an item at the bottom, or a sub-pixel offset), no
animation runs and scrollingStopped() was never emitted. Callers waiting
for it stayed blocked: KItemListView::scrollToItem() delegates to scrollTo
for any non-zero offset, and DolphinView::renameSelectedItems() only opens
the inline rename editor once scrollingStopped() arrives. So inline rename
silently did nothing for the affected items.
Emit scrollingStopped() in the no-op case too, and add a regression test.
remove version guards below the build minimums2026-06-13T15:00:09ZMéven Carmeven@kde.org2026-06-13T14:28:08Zurn:sha1:d49b4aa1bc826bc2343f518af6712981228f1c8e
KIO_VERSION and KFILEMETADATA_VERSION checks up to 6.23 are always true
given the Qt 6.4 / KF 6.23 minimum versions.
Allow grouping by a separate criterion2026-06-11T10:30:18ZRamil Nurmanovramil2004nur@gmail.com2026-06-04T20:06:12Zurn:sha1:989c0f4f0319f7d8e573c8a88fe8011bd3315466
Add an explicit group role to Dolphin views so items can be grouped independently from the active sort role.
Previously, Dolphin's grouped view always used the current sort role as the grouping criterion. This meant that grouping and sorting were tied together, for example grouping by type also required sorting by type.
This change adds a separate Group By menu. It replaces the previous Show in Groups toggle and allows the user to disable grouping, keep the old Same as Sort behavior, or explicitly group by a selected criterion.
When an explicit group role is set, the model keeps groups stable and uses the normal sort role as a secondary key inside each group. The roles
updater also receives the active group role, so roles used only for grouping are still updated correctly.
BUG: 416134
CCBUG: 510670
CCBUG: 513235
CCBUG: 46393
kitemviews: handle macOS pixel wheel scrolling immediately2026-06-10T11:33:48ZKetal Wangk@ketal.icu2026-05-29T10:14:59Zurn:sha1:6eed05fd769b01c37530b8b62cdcd65933ea8d14kfileitemmodel: prefer prefix over postfix increment for iterator2026-06-01T09:04:16ZSebastian Englbrechtsebastian.englbrecht@tum.de2026-05-31T17:05:52Zurn:sha1:4b68a7ca5ea08df4bc108dfcb645fd8a067df7f2
Postfix increment creates an unnecessary temporary copy.
dolphinview: Unselect navigator when click on background2026-05-31T08:57:56ZFlorian RICHERflorian.richer@protonmail.com2026-05-15T15:29:46Zurn:sha1:2a72145eb09276a4576762b74cb976fcd4550e87KItemListWidget: Add pressedChanged2026-05-29T12:59:42ZAkseli Lahtinenakselmo@akselmo.dev2026-05-29T10:25:07Zurn:sha1:8f0baa45053312914812cc908e94138bc23fe44f
When items were pressed, we never called the
updateAdditionalInfoTextColor, which caused
some of the text colors get out of sync.
This was especially noticeable in details view
when using an accent color that makes the font
color change to preserve readability.
BUG: 508329
dolphinmainwindow,kitemlistview: fix unowned object allocations2026-05-28T08:59:00ZSebastian Englbrechtsebastian.englbrecht@tum.de2026-05-23T15:40:53Zurn:sha1:680ccee08cfac2b53bb7bf7d35b780889efa4b51
Parent QMenu to the main window so it is owned and deleted with it.
Register KItemListContainerAccessible in Qt's accessibility cache so
Qt takes ownership and deletes it with the container widget.