dolphin/src/kitemviews, branch masterPatched KDE Dolphin with Pixel Scalinghttps://fiftyfourth.xyz/git/dolphin/atom/src/kitemviews?h=master2026-06-01T09:04:16Zkfileitemmodel: prefer prefix over postfix increment for iterator2026-06-01T09:04:16ZSebastian Englbrechtsebastian.englbrecht@tum.de2026-05-31T17:05:52Zurn:sha1:4b68a7ca5ea08df4bc108dfcb645fd8a067df7f2
Postfix increment creates an unnecessary temporary copy.
dolphinview: Unselect navigator when click on background2026-05-31T08:57:56ZFlorian RICHERflorian.richer@protonmail.com2026-05-15T15:29:46Zurn:sha1:2a72145eb09276a4576762b74cb976fcd4550e87KItemListWidget: Add pressedChanged2026-05-29T12:59:42ZAkseli Lahtinenakselmo@akselmo.dev2026-05-29T10:25:07Zurn:sha1:8f0baa45053312914812cc908e94138bc23fe44f
When items were pressed, we never called the
updateAdditionalInfoTextColor, which caused
some of the text colors get out of sync.
This was especially noticeable in details view
when using an accent color that makes the font
color change to preserve readability.
BUG: 508329
dolphinmainwindow,kitemlistview: fix unowned object allocations2026-05-28T08:59:00ZSebastian Englbrechtsebastian.englbrecht@tum.de2026-05-23T15:40:53Zurn:sha1:680ccee08cfac2b53bb7bf7d35b780889efa4b51
Parent QMenu to the main window so it is owned and deleted with it.
Register KItemListContainerAccessible in Qt's accessibility cache so
Qt takes ownership and deletes it with the container widget.
KItemListController: remove redundant conditions in drag/release handlers2026-05-28T08:56:45ZSebastian Englbrechtsebastian.englbrecht@tum.de2026-05-26T19:04:40Zurn:sha1:3779fbb7c9f1b22ebc9c61bfcdca42678463b164
newHoveredWidget is already guarded non-null by the enclosing if-block;
!isAboveSelectionToggle is always true after the preceding early return.
Remove both dead sub-expressions.
kitemlistviewaccessible: avoid virtual call in constructor2026-05-28T08:56:34ZSebastian Englbrechtsebastian.englbrecht@tum.de2026-05-27T17:59:56Zurn:sha1:e8cbf8f3c5c56e3473566498880c9a92e54001db
cppcheck warns about calling virtual functions during construction
because dynamic dispatch is not yet fully active at that point.
Replace childCount() with its concrete implementation
view()->model()->count() directly.
KItemListWidgetCreator, KFileItemModelFilter: delete copy operations2026-05-26T18:48:03ZSebastian Englbrechtsebastian.englbrecht@tum.de2026-05-26T18:48:03Zurn:sha1:cf12c8c61d6b5267b3f5755462f000fa69d9c667
Both classes own a raw pointer freed in the destructor. The implicit shallow
copy would cause a double-free.
Mark copy constructor and operator= as = delete.
Found with cppcheck
kfileitemmodelrolesupdater: fix directory item count for large folders2026-05-13T10:40:25ZPan Zhangzhangpan@kylinos.cn2026-05-13T10:40:25Zurn:sha1:914cd9010b52125a01e607c0b0f08401be225106
Dolphin reported an incorrect item count in the "Size" column for directories containing 200 or more entries.
Use KIO::ListJob::ListFlag::ExcludeDotAndDotDot and ExcludeHidden to filter entries at the source.
Use a local counter (totalCount) captured via std::shared_ptr in the lambda to ensure each scan job starts from zero and maintains its own state.
Add a fast path using list.size() when showDirectoriesOnly is false to improve performance.
BUG: 509150
KItemListWidget: stop overriding style‑provided background brush2026-05-08T08:14:54ZEvgeniy Harchenkoevgeniyharchenko.dev@gmail.com2026-05-08T08:14:54Zurn:sha1:a2f56f7ccf5cd41c9286970280bbf29ff2bc96b0
The previous implementation forced a custom background colour
before delegating to the style's PE_PanelItemViewItem primitive.
This interferes with theme‑specific drawing and results in a hard‑coded,
non‑themed highlight that breaks styling across themes.
Remove the explicit brush assignment, allowing the style to
paint the background itself. The focus rectangle handling remains
unchanged and is still drawn only for the active item.
And pass the State_MouseOver to focus rect style option when hovered.
Show type-ahead typing feedback in the status bar2026-04-27T11:26:59ZFelix Ernstfelixernst@zohomail.eu2026-04-23T16:22:49Zurn:sha1:1e13c6abb6fc179fa8da32fe62df89560a801b3d
The typed keys are displayed in the status bar while also displaying
which file name they were auto-completed to (i.e. which file was
selected because of the typing).
This commit contains some refactoring to keep the original status bar
functionality working as expected.
This commit also separates DolphinMainWindow from DolphinStatusBar which
is great news architecture-wise. The status bar is encapsulated within
the DolphinViewContainer.