dolphin/src/panels/information/filemetadataconfigurationdialog.cpp, branch masterPatched KDE Dolphin with Pixel Scaling
https://fiftyfourth.xyz/git/dolphin/atom?h=master2019-04-23T10:36:14Z[InformationPanel] Use the new inline configuration mode2019-04-23T10:36:14ZStefan Brünsstefan.bruens@rwth-aachen.de2019-04-14T00:44:01Zurn:sha1:ecf1ae6d0b1691bfe36fc0ff64500f111f3abc32
Summary:
The current external configuration dialog has some issues:
- its layout is suboptimal, as its initial size is typically to small
- it is quite disassociated with the actual widget it configures, properties
have a different order, and the property names can be quite abstract
without the corresponding value.
Doing the visibility selection inline typically avoids the sizing problem,
as the containing application (dolphin) is often vertically maximized.
The selection becomes more obvious, as the item order is kept,
and the values are shown.
Depends on D20524
CCBUG: 389571
Reviewers: #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg, elvisangelaccio
Reviewed By: #dolphin, elvisangelaccio
Subscribers: elvisangelaccio, meven, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D20525
Port away from kdelibs4support2018-08-20T23:03:33ZElvis Angelaccioelvis.angelaccio@kde.org2018-08-13T21:36:35Zurn:sha1:6674c9c387d0986e99698332727bf797257bf07d
Summary:
It was only used as fallback when baloo was not found, but
`KFileMetaDataWidget` is useless without nepomuk.
The result of this patch is that the information panel and the tooltips
won't be available from platforms without baloo (instead of being
available but broken). The baloo dependency remains optional.
Closes T8720
Test Plan:
Build dolphin with `cmake -DCMAKE_DISABLE_FIND_PACKAGE_KF5Baloo=ON ..` and
make sure it doesn't show tooltips or the information panel.
Reviewers: #dolphin, broulik, ngraham
Subscribers: kfm-devel
Tags: #dolphin
Maniphest Tasks: T8720
Differential Revision: https://phabricator.kde.org/D14814
Remove unused #include2018-03-04T18:00:47ZRoman Inflianskasinfroma@gmail.com2018-03-04T13:38:16Zurn:sha1:48b58f830a585b773435c9af5ee2fe8f0c7c641d
Summary: I used CLion inspection to hunt all unused #include
Reviewers: #dolphin, elvisangelaccio, markg
Reviewed By: #dolphin, elvisangelaccio, markg
Subscribers: bcooksley, markg, elvisangelaccio, #dolphin
Differential Revision: https://phabricator.kde.org/D10985
Modernize the syntax of shortcuts2018-03-03T13:44:29ZRoman Inflianskasinfroma@gmail.com2018-03-03T08:46:14Zurn:sha1:32bd8efc7f08a30622deaa3a80b7b26ceaea9f29
Reviewers: #dolphin, markg
Reviewed By: markg
Subscribers: markg, elvisangelaccio, #dolphin
Differential Revision: https://phabricator.kde.org/D10986
Use nullptr + add explicit keyword2017-11-03T13:54:06ZMontel Laurentmontel@kde.org2017-11-03T07:01:02Zurn:sha1:ff3f476ed816cff5fc38117979d181707f934639
Test Plan: compile
Reviewers: #dolphin, broulik
Reviewed By: broulik
Subscribers: #dolphin
Differential Revision: https://phabricator.kde.org/D8637
[CLAZY] Fixed all level 1 and level 2 warnings with small exceptions2016-03-16T21:17:37ZArtur Puziocytadela88@gmail.com2016-03-16T21:17:37Zurn:sha1:5593c252e8d9638c86dcc2bb9edd394ea14f8ba1
REVIEW: 126771
Port to QDialog2014-10-28T20:49:53ZMontel Laurentmontel@kde.org2014-10-28T20:49:53Zurn:sha1:422dc4e921c83265453b6e3ea1d911c051bf8270Fix includes2014-10-18T12:42:41ZMontel Laurentmontel@kde.org2014-10-18T12:42:41Zurn:sha1:31a0c4fbd59c93a48f093be62b8ef19e6839de37Remove the automoc noise2014-06-29T08:36:32ZChristophe Giboudeauxcgiboudeaux@gmx.com2014-06-29T08:36:32Zurn:sha1:a7692611315065b308cd8243563cc50d40bd0f71Revert "Fix build"2014-06-27T16:05:36ZChristophe Giboudeauxcgiboudeaux@gmx.com2014-06-27T16:05:36Zurn:sha1:7fa0c566eda0f954dd005b72bc61befe41daf55f
This reverts commit 780e76f35bca0ced37a691a50367cf705388cc38.
Update your kfilemetadata/baloo/baloo-widgets builds instead.