dolphin/src/panels/information/filemetadataconfigurationdialog.h, branch master

[InformationPanel] Use the new inline configuration mode

2019-04-23T10:36:14Z

Summary: The current external configuration dialog has some issues: - its layout is suboptimal, as its initial size is typically to small - it is quite disassociated with the actual widget it configures, properties have a different order, and the property names can be quite abstract without the corresponding value. Doing the visibility selection inline typically avoids the sizing problem, as the containing application (dolphin) is often vertically maximized. The selection becomes more obvious, as the item order is kept, and the values are shown. Depends on D20524 CCBUG: 389571 Reviewers: #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, meven, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20525

Remove last traces of KFileMetaDataWidget from information panel

2019-04-14T12:59:00Z

Summary: The whole information panel is not included when Baloo is not found, so there is no need for the HAVE_BALOO guards. KFileMetaDataWidget and KFileMetaDataConfigurationWidget were never part of KF5, see https://git.reviewboard.kde.org/r/113153/ Test Plan: ctest Reviewers: #frameworks, apol, ngraham, #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D20513

Port away from kdelibs4support

2018-08-20T23:03:33Z

Summary: It was only used as fallback when baloo was not found, but `KFileMetaDataWidget` is useless without nepomuk. The result of this patch is that the information panel and the tooltips won't be available from platforms without baloo (instead of being available but broken). The baloo dependency remains optional. Closes T8720 Test Plan: Build dolphin with `cmake -DCMAKE_DISABLE_FIND_PACKAGE_KF5Baloo=ON ..` and make sure it doesn't show tooltips or the information panel. Reviewers: #dolphin, broulik, ngraham Subscribers: kfm-devel Tags: #dolphin Maniphest Tasks: T8720 Differential Revision: https://phabricator.kde.org/D14814

Fix build without Baloo

2018-03-07T07:55:04Z

That include IS used

Remove unused #include

2018-03-04T18:00:47Z

Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985

Fix all krazy #include warnings

2018-02-04T10:38:50Z

- "include own header first line" - "put config.h in angle brackets line" - "do not include QtModule/QtClass line" `QElapsedTimer` was implicitly included by kfileitemmodelsortalgorithm.h, now we need to explicitly include it in kfileitemmodel.cpp. We also need to explicitly link to `Qt5::Concurrent`, otherwise we cannot `#include `.

Modernize: Use nullptr everywhere

2017-11-21T09:53:12Z

Modernize: Use override where possible

2017-11-20T22:25:48Z

Also use override instead of Q_DECL_OVERRIDE

Port to QDialog

2014-10-28T20:49:53Z

Port Dolphin to Baloo

2014-02-06T19:29:09Z

Nepomuk is being replaced with Baloo