dolphin/src/panels/information/informationpanelcontent.cpp, branch masterPatched KDE Dolphin with Pixel Scaling
https://fiftyfourth.xyz/git/dolphin/atom?h=master2025-11-20T09:13:25Zinformationpanel: prevent a crash when creating video preview panel and a media file is selected 2025-11-20T09:13:25ZJean-Baptiste Mardellejb@kdenlive.org2025-09-19T11:31:03Zurn:sha1:580c31cccee1646db85bbf3a033911858bf79d7a
To reproduce the crash:
- Open Dolphin, disable information panel and close Dolphin
- Re-open Dolphin
- Select a video file
- Enable information panel
- Crash
Problem is that some elements of the MediaWidget panel are created when the widget is shown, in `showEvent` (`m_seekSlider` and `m_topLayout`), and these elements are called before being created.
This MR fixes 2 different crashes:
- Crash creating panel when a video file is selected (call to `m_seekSlider` before its creation)
- Crash creating panel when a video file is selected and autoplay enabled (call to `m_topLayout` before its creation)
informationpanelcontent: prevent repeated disabled effect on previews2025-09-28T04:12:03ZPan Zhangzhangpan@kylinos.cn2025-09-26T02:27:41Zurn:sha1:96019a8592788932443fe0d0efc8ea44af2cf948
When switching files quickly in the Information Panel, the preview pixmap could appear progressively brighter/whiter. This happened because markOutdatedPreview() was applying KIconEffect::toDisabled() multiple times on the same pixmap while a preview job was still pending.
This patch fixes the issue by:
- Tracking the URL that was last disabled, and only applying the disabled effect once per URL.
- Clearing the disabled state whenever a new preview job starts or when a new pixmap is shown.
With this change, the "disabled preview" effect is preserved (still useful for slow HDD or network filesystems), but the progressive white-out artifact no longer occurs when navigating rapidly.
BUG: 507844
informationpanel: use QTextEdit for filename display to avoid newlines in copied text2025-09-12T08:29:47ZWeinan Liliweinan@kylinos.cn2025-09-10T07:19:36Zurn:sha1:112f375ec175e5aedfb58a3a3bf76535cc959575
QLabel does not support line wrapping at arbitrary positions. The original code achieved word wrap by manually adding newline characters to the text, which resulted in these newlines being included when the filename was selected and copied.
This patch replaces QLabel with QTextEdit for filename display, leveraging QTextEdit's built-in word wrap functionality that handles line breaks purely for display without modifying the underlying text. This ensures copied filenames remain free of unintended newlines.
BUG: 493279
mediawidget: bind arrow keys to slide in media2025-06-28T09:55:38ZMéven Carmeven@kde.org2025-05-03T09:13:33Zurn:sha1:58c48052c38e5bb4f6cf8047dc71e40cfbf04403InformationPanel: Port from Phonon to QtMultimedia2025-06-28T09:55:38ZMéven Carmeven29@gmail.com2019-06-23T15:36:38Zurn:sha1:8216a67d58af0fd709bb3bfb8d0b6073b11cdfedRefactor Overlay Handling2025-01-17T10:07:40ZMéven Carmeven@kde.org2025-01-14T17:52:36Zurn:sha1:961e6270e4401a6c7512df3a2e3efd09a25df962
Now all overlays icons in kitemviews are added in
KStandardItemListWidget::updatePixmapCache.
data[iconOverlays] now contains icon names.
DolphinFileItemListWidget::refreshCache is the sole responsible of
setting the overlays either coming from KFileItemModelRolesUpdater or
KVersionControlPlugin.
This garantees consistency in rendering.
BUG: 497372
Clean stop-gap porting ifdef for KICONTHEMES_VERSION2025-01-15T08:57:37ZMéven Carmeven@kde.org2025-01-15T08:57:37Zurn:sha1:7f12389a9553fab558e09e8845aebb26e8a7d9eb
That were introduced in:
a55c467fbb31d822d89722812388425327830377
38ab14c87a945153e683657483fa4bcf44d6b0fb
Icons: when adding overlays pass in the output size2025-01-11T12:19:57ZMéven Carmeven@kde.org2025-01-10T09:05:32Zurn:sha1:fe56127d9e90c2b364189d38ea43c64ee2019874
Instead of the pixmap size that won't be accurate.
It allow KGuiAddons::addOverlays to draw larger images to add overlays.
Consequently the emblems are not longer dependant scaled based on the pixmap aspect
ratio.
BUG: 498211
information panel: scale according dpr2025-01-09T09:44:39ZMéven Carmeven@kde.org2025-01-06T17:23:12Zurn:sha1:863c1be871d7dbd16800cf7400284783d52352d5
Also use dpr for icons.
Amends cebcf8db
BUG: 497576
Port from KIconLoader::drawOverlays to KIconUtils::addOverlays2024-07-27T11:52:55ZNicolas Fellanicolas.fella@gmx.de2024-07-26T22:11:31Zurn:sha1:cebcf8dbb3ff310aa0761ad452e4ca79278d7831
The latter is what most other projects use