<feed xmlns='http://www.w3.org/2005/Atom'>
<title>dolphin/src/panels/places/placesitemmodel.cpp, branch master</title>
<subtitle>Patched KDE Dolphin with Pixel Scaling
</subtitle>
<id>https://fiftyfourth.xyz/git/dolphin/atom?h=master</id>
<link rel='self' href='https://fiftyfourth.xyz/git/dolphin/atom?h=master'/>
<link rel='alternate' type='text/html' href='https://fiftyfourth.xyz/git/dolphin/'/>
<updated>2022-01-09T17:09:10Z</updated>
<entry>
<title>Port back to KFilePlacesView</title>
<updated>2022-01-09T17:09:10Z</updated>
<author>
<name>Kai Uwe Broulik</name>
<email>kde@privat.broulik.de</email>
</author>
<published>2021-12-16T18:29:22Z</published>
<link rel='alternate' type='text/html' href='https://fiftyfourth.xyz/git/dolphin/commit/?id=0603e18cd4e36b988196a99810f2e3e803fe3125'/>
<id>urn:sha1:0603e18cd4e36b988196a99810f2e3e803fe3125</id>
<content type='text'>
This removes the custom-view engine version of the places panel
and replaces it with the upstream `KFilePlacesView` from KIO.
</content>
</entry>
<entry>
<title>Remove a missing emit KEYWORD</title>
<updated>2021-02-14T14:21:22Z</updated>
<author>
<name>Méven Car</name>
<email>meven29@gmail.com</email>
</author>
<published>2021-02-14T14:21:22Z</published>
<link rel='alternate' type='text/html' href='https://fiftyfourth.xyz/git/dolphin/commit/?id=61a4ae4d3f43c88cfabba107914cc1cb7354d2ee'/>
<id>urn:sha1:61a4ae4d3f43c88cfabba107914cc1cb7354d2ee</id>
<content type='text'>
NO_CHANGELOG
</content>
</entry>
<entry>
<title>Compile with QT_NO_KEYWORDS</title>
<updated>2020-10-23T18:23:06Z</updated>
<author>
<name>Alexander Lohnau</name>
<email>alexander.lohnau@gmx.de</email>
</author>
<published>2020-10-23T17:51:33Z</published>
<link rel='alternate' type='text/html' href='https://fiftyfourth.xyz/git/dolphin/commit/?id=97415729c34851df75c77a67f27d6299c00bfbc4'/>
<id>urn:sha1:97415729c34851df75c77a67f27d6299c00bfbc4</id>
<content type='text'>
</content>
</entry>
<entry>
<title>Show home folder if needed after unmounting mounted disk</title>
<updated>2020-10-23T17:00:09Z</updated>
<author>
<name>Nate Graham</name>
<email>nate@kde.org</email>
</author>
<published>2020-10-13T17:51:59Z</published>
<link rel='alternate' type='text/html' href='https://fiftyfourth.xyz/git/dolphin/commit/?id=ae1d441dacef7e52984201abdc9a918ce060021c'/>
<id>urn:sha1:ae1d441dacef7e52984201abdc9a918ce060021c</id>
<content type='text'>
Right now, when you unmount a device that any active view containers are
displaying, nothing in the view changes. As a result, it's possible to
try to navigate to files or folders in that view, which cannot be done
because the disk that the files or folders are located on has been
unmounted!

With this commit, we detect that case and switch the view containers
to show the home folder after the disk whose contents they are displaying
gets unmounted.

BUG: 158934
FIXED-IN: 20.12
</content>
</entry>
<entry>
<title>Output of licensedigger + manual cleanup afterwards.</title>
<updated>2020-08-25T17:07:38Z</updated>
<author>
<name>Elvis Angelaccio</name>
<email>elvis.angelaccio@kde.org</email>
</author>
<published>2020-08-25T17:07:38Z</published>
<link rel='alternate' type='text/html' href='https://fiftyfourth.xyz/git/dolphin/commit/?id=954e8c47906c12edaaf6e6aebdd41516eceb0d44'/>
<id>urn:sha1:954e8c47906c12edaaf6e6aebdd41516eceb0d44</id>
<content type='text'>
Unfortunately licensedigger does not strip the trailing * characters.
While at it, use a common style for all source files.
</content>
</entry>
<entry>
<title>PlacesItemModel: remove redundant set of properties</title>
<updated>2019-11-10T09:03:25Z</updated>
<author>
<name>Elvis Angelaccio</name>
<email>elvis.angelaccio@kde.org</email>
</author>
<published>2019-11-09T21:45:11Z</published>
<link rel='alternate' type='text/html' href='https://fiftyfourth.xyz/git/dolphin/commit/?id=2e9f6a7abf6cda1e94be0b448785a3b1f75b5579'/>
<id>urn:sha1:2e9f6a7abf6cda1e94be0b448785a3b1f75b5579</id>
<content type='text'>
Summary:
The text, icon and url properties are already set in
`PlacesItem::setBookmark()`, so there is no need to set them here.

The `OnlyInApp` property is part of the KBookmark object that we are
going to set to the place item, so there is no need to set it here either.

Test Plan:
- Open both dolphin and the Plasma file dialog in some app
- Edit the text, url, icon and the "Only show when using this application" checkbox in some place item from the file dialog
- Check whether the place in dolphin keeps getting updated accordingly

Reviewers: #dolphin, meven, ngraham

Subscribers: kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D25230
</content>
</entry>
<entry>
<title>Remove unnecessary semicolons after Q_UNUSED</title>
<updated>2019-11-09T21:09:16Z</updated>
<author>
<name>Elvis Angelaccio</name>
<email>elvis.angelaccio@kde.org</email>
</author>
<published>2019-11-09T21:06:39Z</published>
<link rel='alternate' type='text/html' href='https://fiftyfourth.xyz/git/dolphin/commit/?id=16a3aea6a629a91aab937be5c111b64b3ed6cf86'/>
<id>urn:sha1:16a3aea6a629a91aab937be5c111b64b3ed6cf86</id>
<content type='text'>
GIT_SILENT
</content>
</entry>
<entry>
<title>Fix clazy non-pod-global-static warning</title>
<updated>2019-11-09T21:09:16Z</updated>
<author>
<name>Elvis Angelaccio</name>
<email>elvis.angelaccio@kde.org</email>
</author>
<published>2019-11-09T18:42:57Z</published>
<link rel='alternate' type='text/html' href='https://fiftyfourth.xyz/git/dolphin/commit/?id=273fc202fd66262ca34adb424897e08137282bab'/>
<id>urn:sha1:273fc202fd66262ca34adb424897e08137282bab</id>
<content type='text'>
This list of URLs is only used by cleanupBookmarks(), so there is no
need to make it global (which is what clazy complains about).

While at it, make it also a `const QVector`.
</content>
</entry>
<entry>
<title>Unmounting busy device doesn't tell who is blocking</title>
<updated>2019-10-27T05:52:25Z</updated>
<author>
<name>David Hallas</name>
<email>david@davidhallas.dk</email>
</author>
<published>2019-03-23T08:16:17Z</published>
<link rel='alternate' type='text/html' href='https://fiftyfourth.xyz/git/dolphin/commit/?id=c3b914a7faed3a7c0195ae77b40204cbc8d31fe5'/>
<id>urn:sha1:c3b914a7faed3a7c0195ae77b40204cbc8d31fe5</id>
<content type='text'>
Summary: Unmounting a busy device from the places panel doesn't tell which applications have open files blocking the unmount.

Test Plan:
Mount a USB stick using Dolphin
Open a file from the USB stick
Unmount the USB stick using Dolphin
Observe the new error message.

FEATURE: 189302

Reviewers: #dolphin, elvisangelaccio, ngraham, broulik, meven

Reviewed By: #dolphin, elvisangelaccio, meven

Subscribers: meven, davidedmundson, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D19989
</content>
</entry>
<entry>
<title>Fix rearranging items in places panel with hidden items</title>
<updated>2019-03-20T16:46:15Z</updated>
<author>
<name>Tigran Gabrielyan</name>
<email>tigrangab@gmail.com</email>
</author>
<published>2019-03-20T09:21:21Z</published>
<link rel='alternate' type='text/html' href='https://fiftyfourth.xyz/git/dolphin/commit/?id=303cd17444e1fb88d1f92a911f7c770214b8f90e'/>
<id>urn:sha1:303cd17444e1fb88d1f92a911f7c770214b8f90e</id>
<content type='text'>
Summary:
`m_sourceModel-&gt;movePlace` is called using index from the view model.
This becomes an issue when there are hidden places items.

This change calls `m_sourceModel-&gt;movePlace` using the corresponding mapped source index.

BUG: 399430
FIXED-IN: 19.04.0

Test Plan:
  # Create at least 4 Places items
  # Hide first item
  # Drag the now first visible item between second and third item

Actual: The item does not move
Expected: The first visible item should now be second visible item in the list

Reviewers: #dolphin, ngraham

Reviewed By: #dolphin, ngraham

Subscribers: ngraham, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D19901
</content>
</entry>
</feed>
