Patched KDE Dolphin with Pixel Scaling https://fiftyfourth.xyz/git/dolphin/atom?h=pixelated-scaling-option 2025-04-07T21:09:00Z 2025-04-07T21:09:00Z Felix Ernst felixernst@kde.org 2025-04-07T21:09:00Z urn:sha1:4102ccb80457eea44ea280f0ace2a419602bc34b This huge commit is a nearly complete rewrite of the Dolphin search code. It implements most of the improved Dolphin search UI/UX as designed and discussed in a collaborative effort by Kristen McWilliam, Jin Liu, Andy Betts, Tagwerk, a few others and me. See https://invent.kde.org/system/dolphin/-/issues/46. # Notable changes - A toggle to change the search tool is provided as most contributors deemed that useful in https://invent.kde.org/system/dolphin/-/merge_requests/642#note_985112. - The default search is changed to filenamesearch for maximum reliability. - Removing all search parameters will take users back to the view state prior to starting a search instead of keeping the search results open. - The UI for choosing file types or modification dates has been made more powerful with more granularity and more options. - Most search parameters can be configured from a popup menu which gives us extra space for extra clarity. - Labels and help buttons as well as hyperlinks to settings makes sure the user always knows why some search parameters are unavailable in some contexts. - Chips show important search parameters while the popup is closed. They allow quickly removing filters. - The titles of the search and the input field placeholder message change to make clear whether file names or file contents are searched. - When the user actively switches the search tool, whether content should be searched, or whether to search everywhere, this is preserved for the initial state of the search bar when the user opens it the next time after restarting Dolphin. # Architecture - The new DolphinQuery class is independent of the UI and contains all search parameters modifiable in Dolphin as easy setters and getters. - DolphinQuery objects are also used to update the states of every component in the search UI. There is now a clear separation of UI and search configuration/DolphinQuery. - DolphinQuery is responsible for exporting to and importing from search URLs. - The search UI always reflects the currently configured DolphinQuery no matter if the user changed the UI to change the DolphinQuery or loaded a DolphinQuery/older search URL which then is reflected in the UI. - I tried to simplify all classes and their interaction between each other as much as possible. - I added some tests BUG: 386754 CCBUG: 435119 CCBUG: 458761 BUG: 446387 BUG: 470136 CCBUG: 471556 CCBUG: 475439 CCBUG: 477969 BUG: 480001 BUG: 483578 BUG: 488047 BUG: 488845 BUG: 500103 FIXED-IN: 25.08 2019-11-03T22:00:36Z Ismael Asensio isma.af@gmail.com 2019-11-03T22:00:36Z urn:sha1:54bd267eb96de135d2bf4cb91c6a16dffa0b012a Summary: With the new compact search filters (type/date/rating) it makes sense to show these options whenever available, and save some horizontal space on the main bar (specially for verbose languages). These options will be hidden nevertheless if the search is non-indexed or Baloo is disabled. For some nicer aesthetics D25029 should be also applied. CCBUG: 386754 Test Plan: Current: {F7681182} After: {F7687380} Along with D25029: {F7687385} Reviewers: elvisangelaccio, ngraham, #dolphin, #vdg Reviewed By: ngraham, #vdg Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25057 2012-04-25T00:20:25Z Peter Penz peter.penz19@gmail.com 2012-04-25T00:16:35Z urn:sha1:67f58d5082cbab3a1a4a83926e77ade299ec07ea The places-entries for searching revealed some serious issues in combination with the search-panel. Move the filtering away from QDockWidget and bring it back below the search-bar. 2010-08-07T18:19:31Z Peter Penz peter.penz19@gmail.com 2010-08-07T18:19:31Z urn:sha1:e85afe10979ecb7e93d7371c1d51e9b7ffcee53b svn path=/trunk/KDE/kdebase/apps/; revision=1160311 2010-07-24T16:37:07Z Peter Penz peter.penz19@gmail.com 2010-07-24T16:37:07Z urn:sha1:49eb864b03b6370e403c6f048ab18d1478eab045 svn path=/trunk/KDE/kdebase/apps/; revision=1154073 2009-11-24T07:20:36Z Peter Penz peter.penz19@gmail.com 2009-11-24T07:20:36Z urn:sha1:981feb40aa80ac4d31c3971f834742348ecad78b svn path=/trunk/KDE/kdebase/apps/; revision=1053448 2009-11-23T15:58:22Z Andrew Coles andrew.i.coles@googlemail.com 2009-11-23T15:58:22Z urn:sha1:f821db58becdb8f140935d88adc58547f0008d22 svn path=/trunk/KDE/kdebase/apps/; revision=1053196 2009-11-22T10:22:29Z Peter Penz peter.penz19@gmail.com 2009-11-22T10:22:29Z urn:sha1:aeaec1c2d18a13e0dd7f36acc93042dc0b6ee7c6 svn path=/trunk/KDE/kdebase/apps/; revision=1052677