dolphin/src/selectionmode/bottombar.h, branch master Patched KDE Dolphin with Pixel Scaling https://fiftyfourth.xyz/git/dolphin/atom?h=master 2024-03-13T15:39:00Z Animate most of the bars 2024-03-13T15:39:00Z Felix Ernst felixernst@kde.org 2024-03-13T15:39:00Z urn:sha1:f588a7d48b7cef5351d8b0f030a6ec5e76229976 When a bar is toggled visible this usually happens because the user might want to use its functionality now. However, if bars appear without animation or at a location the user is not currently looking at, they might not notice that they have appeared at all. An animation makes it more likely that the user notices the change and can then use the newly made visible component. Another reason for animations for showing or hiding of components is that it can be disorienting for users when panels or bars suddenly appear or disappear without animation. There is no visible movement then, so the user might not know what happened if they didn't concentrate or blink at that moment. The newly appearing or disappearing component might also displace other components which can make it difficult to find what one was just looking at. These bars animate now after this change: - Search panel - Filter bar - Status bar This is implemented by extracting the animation code from SelectionMode::TopBar into a new abstract base class AnimatedHeightWidget. This class is now also used in SelectionMode::BottomBar and the animating code there was removed. These bars are left in Dolphin that stay without animation: - Menu bar (Would probably need to be implemented in KXmlGui) - Tool bar (Would probably need to be implemented in KXmlGui) - Tab bar (Needs a different appraoch because it already inherits QTabBar and therefore can not inherit AnimatedHeightWidget) Update my eMail to the KDE-provided one 2023-06-04T16:09:42Z Felix Ernst felixernst@zohomail.eu 2023-06-04T16:09:42Z urn:sha1:e5abe2c67bed7f1ca448cc94eb3abcfbe7d0da92 GIT_SILENT NO_CHANGELOG Add clang-format and format code as in Frameworks 2023-02-05T05:45:38Z Serg Podtynnyi serg@podtynnyi.com 2023-02-03T17:14:53Z urn:sha1:38c34eeca315c7be58e65d4d3fb72aaf7b866719 Not use forward and includes 2022-12-26T12:22:44Z Laurent Montel montel@kde.org 2022-12-26T12:22:44Z urn:sha1:2aa64b2c38f1cc36e0adb02082057cdc671238e6 Improve naming consistency and leave mode on Escape 2022-08-14T14:42:40Z Felix Ernst fe.a.ernst@gmail.com 2022-04-28T20:55:28Z urn:sha1:2e588733c759cccd2d86e34a3a394b9a8ab0c800 Improve code quality 2022-08-14T14:42:40Z Felix Ernst fe.a.ernst@gmail.com 2022-04-25T10:52:05Z urn:sha1:78cffd2979a6ed87e044fcb024cf4fdfc5c7cb3d Better separation of classes 2022-08-14T14:42:40Z Felix Ernst fe.a.ernst@gmail.com 2022-04-24T11:18:30Z urn:sha1:8e55f2c2409fd6ca9ebc66a6568f4d3bcbef7576 Make obvious when actions trigger selection mode.