dolphin/src/selectionmode/bottombarcontentscontainer.cpp, branch masterPatched KDE Dolphin with Pixel Scaling
https://fiftyfourth.xyz/git/dolphin/atom?h=master2026-01-22T16:18:41Zclang-format: readability-avoid-return-with-void-value2026-01-22T16:18:41ZMéven Carmeven@kde.org2026-01-22T16:12:15Zurn:sha1:e692a6a13c6dd7933a47d65046027530612a19d8clang-tidy: fix modernize-loop-convert2026-01-22T16:18:41ZMéven Carmeven@kde.org2026-01-22T16:08:11Zurn:sha1:1bfd5edb5a573cd62a594d5dc6a1a5b35232ac05Use Q_ASSERT instead of Q_CHECK_PTR for plain checks of pointer value2026-01-10T15:14:26ZFriedrich W. H. Kossebaukossebau@kde.org2026-01-09T15:16:48Zurn:sha1:5fff1e414a060c0619a97ad8d3f5665e3f5a4878
Q_CHECK_PTR (other than the name suggests) is intended only to check the
success of memory allocations.
Using it for any pointers instead can be misleading due to the
"Out of memory" log printed in case of hits.
Bottomcontentscontainer: don't pass a parent for a sub-layout2025-10-21T10:53:15ZMéven Carmeven@kde.org2025-10-21T10:53:15Zurn:sha1:832141776a88607179cc7aa487a1d86baacface9
Layouts are parented to their containing layout by default, and layouts
can't share a same parent.
This prevent a runtime warning regarding QLayout.
Fix several user-facing and non-user-facing typos2025-09-03T12:04:13ZKunda Kiluzpaz@pm.me2025-09-03T12:04:13Zurn:sha1:479ce3a1641398a8506812300834666614013850
Found via `codespell -S "*.desktop,*.po,*.svg,*.xml,./po" -L aparent,childs,goup,lokal`Fix crash while entering selection mode with Qt6.72024-04-17T07:32:27ZFelix Ernstfelixernst@kde.org2024-04-17T07:32:27Zurn:sha1:a07f24228a94aab2bdeb3caaf7a4d694c0180ed7
`deleteLater()` on a non-existing object seems to cause a crash with
Qt6.7. This makes some sense but wasn't the case previously.
I didn't test this yet but it is a harmless change so if anyone can confirm we can IMO merge directly.
This was brought up in https://invent.kde.org/system/dolphin/-/merge_requests/764#note_920935, reported in the bug linked below, and the sentry crash reporting page also has a few dozen reports (https://crash-reports.kde.org/organizations/kde/issues/13589/?project=4&query=is%3Aunresolved&referrer=issue-stream&stream_index=1).
Dolphin 24.02 is also affected but we are already past the last bug fix release for it.
BUG: 485599
Fix a bunch of clazy warnings2023-08-29T07:18:51ZMéven Carmeven@kde.org2023-08-28T12:39:00Zurn:sha1:079f903bc8691866b4aa3c3e41204a47e735c062Add explicit moc includes to sources for moc-covered headers2023-07-05T07:59:18ZFriedrich W. H. Kossebaukossebau@kde.org2023-07-04T20:07:48Zurn:sha1:ed2d352c42a6d517d4f29b3582c0e00aa34fe647
* speeds up incremental builds as changes to a header will not always
need the full mocs_compilation.cpp for all the target's headers rebuild,
while having a moc file sourced into a source file only adds minor
extra costs, due to small own code and the used headers usually
already covered by the source file, being for the same class/struct
* seems to not slow down clean builds, due to empty mocs_compilation.cpp
resulting in those quickly processed, while the minor extra cost of the
sourced moc files does not outweigh that in summary.
Measured times actually improved by some percent points.
(ideally CMake would just skip empty mocs_compilation.cpp & its object
file one day)
* enables compiler to see all methods of a class in same compilation unit
to do some sanity checks
* potentially more inlining in general, due to more in the compilation unit
* allows to keep using more forward declarations in the header, as with the
moc code being sourced into the cpp file there definitions can be ensured
and often are already for the needs of the normal class methods
Update my eMail to the KDE-provided one2023-06-04T16:09:42ZFelix Ernstfelixernst@zohomail.eu2023-06-04T16:09:42Zurn:sha1:e5abe2c67bed7f1ca448cc94eb3abcfbe7d0da92
GIT_SILENT
NO_CHANGELOG
Add clang-format and format code as in Frameworks2023-02-05T05:45:38ZSerg Podtynnyiserg@podtynnyi.com2023-02-03T17:14:53Zurn:sha1:38c34eeca315c7be58e65d4d3fb72aaf7b866719