Patched KDE Dolphin with Pixel Scaling https://fiftyfourth.xyz/git/dolphin/atom?h=pixelated-scaling-option 2026-01-22T16:18:41Z 2026-01-22T16:18:41Z Méven Car meven@kde.org 2026-01-22T16:12:15Z urn:sha1:e692a6a13c6dd7933a47d65046027530612a19d8 2024-12-29T11:27:18Z Felix Ernst felixernst@kde.org 2024-12-29T11:27:18Z urn:sha1:3696213ccbbe27e9ef3fc85eb97dd32fd669066f Prior to this commit keyboard controls and behaviour of Dolphin's main view were identical no matter if selection mode was enabled or not. While selection mode makes it impossible to accidentally clear the selection by singular mouse clicks, any press of an arrow key on the keyboard would still clear the full selection which goes against selection mode's objective. Furthermore, keyboard-only users had no reason to ever enable selection mode because it made no difference to them. This commit changes this by offering a changed control scheme for key presses while in selection mode. Arrow key presses without modifier now only move focus between items but do no longer clear or change the selection. Similarly, Page Up/Down, Home, and End key presses only move keyboard focus. Enter, Return, and Space key presses now only toggle the selection for the current item. The above controls are however mostly unchanged when combining them with Modifier keys like Shift or Control. The type-ahead feature is also changed in selection mode to only move keyboard focus without changing the selection. This way keyboard users are less likely to clear their selection by mistake. Regression tests are added for these selection mode controls. The code changes to change this keyboard behaviour are quite minimal. Most of the added code is for making selection mode accessible. That's because we need to make sure the changed control scheme is properly announced and communicated or a blind user will be left utterly confused why the normal keyboard controls "stopped working". Enabling or disabling selection mode is announced to accessibility software. Furthermore whenever focus goes to the main view, the selection mode state is also mentioned when active. BUG: 458091 2024-03-13T15:39:00Z Felix Ernst felixernst@kde.org 2024-03-13T15:39:00Z urn:sha1:f588a7d48b7cef5351d8b0f030a6ec5e76229976 When a bar is toggled visible this usually happens because the user might want to use its functionality now. However, if bars appear without animation or at a location the user is not currently looking at, they might not notice that they have appeared at all. An animation makes it more likely that the user notices the change and can then use the newly made visible component. Another reason for animations for showing or hiding of components is that it can be disorienting for users when panels or bars suddenly appear or disappear without animation. There is no visible movement then, so the user might not know what happened if they didn't concentrate or blink at that moment. The newly appearing or disappearing component might also displace other components which can make it difficult to find what one was just looking at. These bars animate now after this change: - Search panel - Filter bar - Status bar This is implemented by extracting the animation code from SelectionMode::TopBar into a new abstract base class AnimatedHeightWidget. This class is now also used in SelectionMode::BottomBar and the animating code there was removed. These bars are left in Dolphin that stay without animation: - Menu bar (Would probably need to be implemented in KXmlGui) - Tool bar (Would probably need to be implemented in KXmlGui) - Tab bar (Needs a different appraoch because it already inherits QTabBar and therefore can not inherit AnimatedHeightWidget) 2023-07-05T07:59:18Z Friedrich W. H. Kossebau kossebau@kde.org 2023-07-04T20:07:48Z urn:sha1:ed2d352c42a6d517d4f29b3582c0e00aa34fe647 * speeds up incremental builds as changes to a header will not always need the full mocs_compilation.cpp for all the target's headers rebuild, while having a moc file sourced into a source file only adds minor extra costs, due to small own code and the used headers usually already covered by the source file, being for the same class/struct * seems to not slow down clean builds, due to empty mocs_compilation.cpp resulting in those quickly processed, while the minor extra cost of the sourced moc files does not outweigh that in summary. Measured times actually improved by some percent points. (ideally CMake would just skip empty mocs_compilation.cpp & its object file one day) * enables compiler to see all methods of a class in same compilation unit to do some sanity checks * potentially more inlining in general, due to more in the compilation unit * allows to keep using more forward declarations in the header, as with the moc code being sourced into the cpp file there definitions can be ensured and often are already for the needs of the normal class methods 2023-06-04T16:09:42Z Felix Ernst felixernst@zohomail.eu 2023-06-04T16:09:42Z urn:sha1:e5abe2c67bed7f1ca448cc94eb3abcfbe7d0da92 GIT_SILENT NO_CHANGELOG 2023-02-05T05:45:38Z Serg Podtynnyi serg@podtynnyi.com 2023-02-03T17:14:53Z urn:sha1:38c34eeca315c7be58e65d4d3fb72aaf7b866719 2022-12-20T20:54:57Z Laurent Montel montel@kde.org 2022-12-20T20:54:57Z urn:sha1:7d3bf84e9dd1f8ec7a9b7becdb08866e9e1e15eb 2022-09-26T06:17:13Z Laurent Montel montel@kde.org 2022-09-26T06:17:13Z urn:sha1:e19aa49a082076d5ae69931893c1d47b98f85e30 2022-09-15T14:18:44Z Felix Ernst fe.a.ernst@gmail.com 2022-09-15T13:19:12Z urn:sha1:f4bed9333e927dabc9a723c1b05eac169605dc68 This way it works just like every other button. This commit also removes two empty files that sneaked in by accident. 2022-08-14T14:42:40Z Felix Ernst fe.a.ernst@gmail.com 2022-05-05T10:54:36Z urn:sha1:261b741d5feb356c1fa8a8ac42397f53eb13ca75 -More labels -More icons -"Abort" -> "Cancel"