dolphin/src/settings/additionalinfodialog.cpp, branch master Patched KDE Dolphin with Pixel Scaling https://fiftyfourth.xyz/git/dolphin/atom?h=master 2018-06-26T20:13:51Z Use collapsible box to configure visible roles 2018-06-26T20:13:51Z Elvis Angelaccio elvis.angelaccio@kde.org 2018-06-26T20:13:51Z urn:sha1:280c97448141d0685806b46af4c80a354f601f26 Summary: A modal dialog that opens another modal dialog is bad UX and should be avoided whenever possible. These days we have `KCollapsibleGroupBox` that can be used to show advanced settings without cluttering the default layout. This change removes the `AdditionalInfoDialog` and uses a collapsible groupbox instead. The `Apply` buttons gets enabled whenever a role gets checked or unchecked, consistently with the existing checkboxes. Test Plan: Change visible roles in the view properties dialog. Reviewers: #dolphin, #vdg Reviewed By: #vdg Subscribers: ngraham, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D13569 Remove unused #include 2018-03-04T18:00:47Z Roman Inflianskas infroma@gmail.com 2018-03-04T13:38:16Z urn:sha1:48b58f830a585b773435c9af5ee2fe8f0c7c641d Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985 Modernize the syntax of shortcuts 2018-03-03T13:44:29Z Roman Inflianskas infroma@gmail.com 2018-03-03T08:46:14Z urn:sha1:32bd8efc7f08a30622deaa3a80b7b26ceaea9f29 Reviewers: #dolphin, markg Reviewed By: markg Subscribers: markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10986 Modernize: Use nullptr everywhere 2017-11-21T09:53:12Z Kevin Funk kfunk@kde.org 2017-11-21T09:52:14Z urn:sha1:a6db5029acc09639fd8c7c20a7676b1ac9f36539 [AdditionalInfoDialog] Prevent hiding "text" role 2017-08-25T14:48:48Z Kai Uwe Broulik kde@privat.broulik.de 2017-08-25T14:48:48Z urn:sha1:dfbaf21218c7a96dd7b7d1c4275820cd94c920f5 You cannot do this from the menu but the option was there (but ignored) in the "View Properties" dialog. BUG: 302622 Differential Revision: https://phabricator.kde.org/D7386 [CLAZY] Fixed all level 1 and level 2 warnings with small exceptions 2016-03-16T21:17:37Z Artur Puzio cytadela88@gmail.com 2016-03-16T21:17:37Z urn:sha1:5593c252e8d9638c86dcc2bb9edd394ea14f8ba1 REVIEW: 126771 Ported Dolphin from KDialog to QDialog and save/restoreDialogSize to KWindowConfig::save/restoreWindowSize with the help of the porting scripts. 2015-02-03T08:25:33Z Emmanuel Pescosta emmanuelpescosta099@gmail.com 2015-02-03T08:25:33Z urn:sha1:3515582495f9aa02369a342d73c11079fcdcd654 REVIEW: 122305 Fix includes 2014-10-18T12:42:41Z Montel Laurent montel@kde.org 2014-10-18T12:42:41Z urn:sha1:31a0c4fbd59c93a48f093be62b8ef19e6839de37 Remove the automoc noise 2014-06-29T08:36:32Z Christophe Giboudeaux cgiboudeaux@gmx.com 2014-06-29T08:36:32Z urn:sha1:a7692611315065b308cd8243563cc50d40bd0f71 Fix build. 2014-06-27T08:34:57Z Christophe Giboudeaux cgiboudeaux@gmx.com 2014-06-27T08:34:57Z urn:sha1:3614b7fea7563300974982cca27a787749ea3f0f