Patched KDE Dolphin with Pixel Scaling https://fiftyfourth.xyz/git/dolphin/atom?h=pixelated-scaling-option 2026-01-22T15:14:16Z 2026-01-22T15:14:16Z Méven Car meven@kde.org 2026-01-22T15:04:09Z urn:sha1:174bc684603326de15e933b3bb24ffb739f3291e 2025-04-24T12:08:25Z Akseli Lahtinen akselmo@akselmo.dev 2025-04-24T12:03:42Z urn:sha1:be36fc1bc45b63693bd5861efed94c08cd9ffe2a The text would get squeezed and elided prematurely due to some clipping calculations and paddings created for the clipping. This slightly modifies the clipping code, that we extend the painted area and then clip off the excess, instead of moving the area to specific place and then clipping off the excess. This also makes sure the text width accounts for one extra character plus the clippings we do, so that text will always fit the statusbar. BUG: 503164 2025-04-22T13:52:50Z Akseli Lahtinen akselmo@akselmo.dev 2025-04-22T13:52:50Z urn:sha1:5d9051bba36c8690a622591b1164158f526a9f12 There is a bug where non-Breeze styles, such as fusion, do not always have background color for the small statusbar. There is also a bug that made the statusbar too small for other themes. This patch makes us always draw a background, and uses marginLeft and marginRight from QStyle. 2025-03-04T16:55:48Z Akseli Lahtinen akselmo@akselmo.dev 2025-03-03T12:02:20Z urn:sha1:d01d6ca476ce89cab3c3cc2ee50d242c74789cb4 During splitview animations the parentWidget()->width could be lower than scrollbarWidth. If it goes to negatives it causes a lot of warnings. Make sure to bound the value between 0 and parentWidget()->width() so that it can't go into negatives. 2025-02-26T11:43:30Z Akseli Lahtinen akselmo@akselmo.dev 2025-02-26T10:30:43Z urn:sha1:fbfe467f8842169ca0410e0e3cee63e4c0861833 Small statusbar should not have zoom slider enabled, but this could be bypassed by using the context menu. If we have small statusbar, just return early instead. 2025-02-24T18:39:22Z Akseli Lahtinen akselmo@akselmo.dev 2025-02-24T18:39:22Z urn:sha1:a27443d904bc220615f2c4e8df74187b0c806d8a - Statusbar has three modes: Small, FullWidth and Disabled - FullWidth is the original statusbar - Small is the new default statusbar - This statusbar overlays on top of the items instead of taking space - It changes size according to content - Disabled turns statusbar completely off - Zoom slider and space information is only shown in full-width statusbar - Space information is now always on - If user navigates with keyboard, or scrolls to selection, the scrolling will take the statusbar into account - This makes sure the statusbar does not cover any items Related discussion: https://invent.kde.org/system/dolphin/-/issues/50 2024-11-12T10:54:25Z Felix Ernst felixernst@zohomail.eu 2024-11-10T15:47:19Z urn:sha1:6c73f7912b6fb0327b9fd0ca7a3fff3b2fb4d5e9 Prior to this commit, when Dolphin was opening in a directory for which the free space information cannot be retrieved, the free space info in the status bar would still briefly be visible before hiding for good. This commit avoids this flickering by keeping the space info hidden until space info has been successfully retrieved. There is no use showing an empty/wrong space info before that anyway. I assume the error in the previous code was that it assumed that one could prevent a widget from being shown by overriding QWidget::showEvent(). This does not work because this method is only called to notify QWidgets of their state change. This commit was primarily written because the brief showing of an empty space info was messing with automatic tests. 2024-10-28T13:25:10Z Felix Ernst felixernst@kde.org 2024-10-28T13:25:10Z urn:sha1:f208acd5f68c8516b9f6a920cc229803637e23e9 This commit brings the main view of Dolphin into a usable state accessibility-wise. Users of screen readers should have a way better experience while browsing files and folders and navigating along the file system hierarchy. This commit fixes most of the remaining already-identified accessibility issues listed in https://invent.kde.org/teams/accessibility/collaboration/-/issues/28, but not all. Namely, these should now be fixed: 1. Orca should read the element type in dolphin (file, folder, device, link to folder, link to file) 2. Orca should read complete label in icon and compact view mode, currently it only speaks the name, but there could be additional information like the number of elements or the file size. 3. Orca is not able to announce Selecting / Unselecting files in Dolphin. It also never announces how many items are selected in total. (Announcing the total selection can be done by reading out the view element or by pressing the Tab key to get to the status bar with the relevant information.) 4. Dolphin opens on the home directory, but Orca doesn't tell you so. Consider enclosing the area in a frame/panel which updates its accessible name each time you modify the current path by entering or leaving a directory. 5. I don't know what the folder presentation widget is, but it should be presented as a grid view. Currently, we have a terrible experience because the entire row of folders is read at once, with no indication that we can move left and right with the arrows to go between the elements of a row. When I found that out, however, I discovered that when you're on the last icon of the first row and press right arrow, you get to the first icon of the next row, but that's not announced, instead, the whole row is announced at once 6. Orca should announce the current elements instead of "layered pane" when the Folder / File view gets the focus in dolphin 7. Orca reads only name in Table View only of Dolphin 8. Items are sometimes confusingly announced as "collapsed" in contexts in which there is no concept of collapsing/expanding e.g. in icon view mode. A lot of code was moved around and renamed. The three accessibility classes, which all used to be in the same file, are moved into separate files. *Acknowledgement* Thanks to Christian Hempfling and bgt lover for testing as well as originally identifying a lot of the pain points being addressed here. This work is part of a my project funded through the NGI0 Entrust Fund, a fund established by NLnet with financial support from the European Commission's Next Generation Internet programme, under the aegis of DG Communications Networks, Content and Technology. https://kde.org/announcements/2024_ngi_openletter/ 2024-07-08T11:41:56Z Felix Ernst felixernst@kde.org 2024-07-08T11:41:56Z urn:sha1:0d981e7b7df266c867004e23a169ba8cc13c8683 Before this commit pressing the free space button when Filelight is not installed would show a singular action called "Install Filelight to View Disk Usage Statistics…". Pressing this button would open the store page for Filelight. This is an okay user experience, but we can do better. This commit makes it so pressing the free space button when Filelight is not installed shows an attractive UI that makes clear that freeing up disk space can be accomplished nicely by installing Filelight. The "Install Filelight…" button on this UI is connected to PackageKit directly, so we do not need to show a separate store like Discover and instead trigger an installation right then and there. For this, the recently introduced DolphinPackageInstaller KJob is used. Installation progress is reported through the status bar similar to the progress reporting of slowly loading directories or searches. Installation failure or success is ultimately shown within Dolphin as a passive notification above the view. On Microsoft Windows or when PackageKit is not available, the install button will only open a store page for Filelight. CCBUG: 477739 2024-06-20T09:45:32Z Felix Ernst felixernst@zohomail.eu 2024-06-13T14:38:41Z urn:sha1:9108534ce07fbdc5e8f037826049c37cf226d2e6 Merge setting title and progress percent into one method. This makes sure that the method can be called from all over the place and will still always show a consistent state instead of partially showing the progress percent for one progress but the label for a different one. This is to enable various tasks reporting progress at the same time in a way that doesn't lead to a confusing mess for users. Usually multiple tasks do not show progress at the same time, but when it happens this commit should make sure that the user experience is at least bearable. Allow not having a "Stop" button next to the progress report for tasks that cannot be stopped.