Patched KDE Dolphin with Pixel Scaling https://fiftyfourth.xyz/git/dolphin/atom?h=pixelated-scaling-option 2026-01-22T15:14:16Z 2026-01-22T15:14:16Z Méven Car meven@kde.org 2026-01-22T15:04:09Z urn:sha1:174bc684603326de15e933b3bb24ffb739f3291e 2025-04-19T12:32:25Z Felix Ernst felixernst@kde.org 2025-04-19T12:32:25Z urn:sha1:b889a446bfe851a7f49821d469c5f3041b6e5774 The menu for installing and launching Filelight was only available through the status bar free space info button until now. By default we do no longer show the free space info button because the status bar has been changed to show less information by default. This commit adds the "Manage Disk Space Usage" menu to the "Tools" menu in the menu bar so it is more discoverable for users. 2024-11-12T10:54:25Z Felix Ernst felixernst@zohomail.eu 2024-11-10T15:47:19Z urn:sha1:6c73f7912b6fb0327b9fd0ca7a3fff3b2fb4d5e9 Prior to this commit, when Dolphin was opening in a directory for which the free space information cannot be retrieved, the free space info in the status bar would still briefly be visible before hiding for good. This commit avoids this flickering by keeping the space info hidden until space info has been successfully retrieved. There is no use showing an empty/wrong space info before that anyway. I assume the error in the previous code was that it assumed that one could prevent a widget from being shown by overriding QWidget::showEvent(). This does not work because this method is only called to notify QWidgets of their state change. This commit was primarily written because the brief showing of an empty space info was messing with automatic tests. 2024-07-08T11:41:56Z Felix Ernst felixernst@kde.org 2024-07-08T11:41:56Z urn:sha1:0d981e7b7df266c867004e23a169ba8cc13c8683 Before this commit pressing the free space button when Filelight is not installed would show a singular action called "Install Filelight to View Disk Usage Statistics…". Pressing this button would open the store page for Filelight. This is an okay user experience, but we can do better. This commit makes it so pressing the free space button when Filelight is not installed shows an attractive UI that makes clear that freeing up disk space can be accomplished nicely by installing Filelight. The "Install Filelight…" button on this UI is connected to PackageKit directly, so we do not need to show a separate store like Discover and instead trigger an installation right then and there. For this, the recently introduced DolphinPackageInstaller KJob is used. Installation progress is reported through the status bar similar to the progress reporting of slowly loading directories or searches. Installation failure or success is ultimately shown within Dolphin as a passive notification above the view. On Microsoft Windows or when PackageKit is not available, the install button will only open a store page for Filelight. CCBUG: 477739 2024-05-30T15:21:39Z Nicolas Fella nicolas.fella@gmx.de 2023-12-11T00:19:15Z urn:sha1:0a8f84a52dcd246550b5ea0e795dd7b309f2ece1 This avoids an empty menu and points the user towards a useful tool BUG: 477739 2024-01-12T17:24:23Z Felix Ernst felixernst@zohomail.eu 2023-12-02T15:18:42Z urn:sha1:83988f5e5bdea84b133fea50f34b807a94ce0732 This is to make sure that users do not have to guess why they would want to press the button. 2023-11-24T11:52:54Z Felix Ernst felixernst@zohomail.eu 2023-11-24T11:18:19Z urn:sha1:139c729b4ab5d0611469f1725468276adcf21f78 This is to make sure that when the window is resized it is less likely that the places panel will be resized only because the status bar doesn't want to become very narrow in width. 2023-11-24T11:52:54Z Felix Ernst felixernst@zohomail.eu 2023-11-18T11:31:00Z urn:sha1:d3637f380ccca26a281331a02ce76ed60e84cfe3 The usage of a label to show this space information is problematic because there are features/actions hidden behind clicking the label. A button makes this clear. It also fixes the accessibility of this control because previously this info would never be read out by screen readers as it couldn't get keyboard focus. A side-effect of this change is that the free disk space bar looks more normal with non-Breeze styles. This had been a long-standing issue. 2023-11-08T13:36:51Z Nicolas Fella nicolas.fella@gmx.de 2023-11-07T14:45:01Z urn:sha1:2cd3d58eec5695899c26ca66a631fb79867b6584 The idea behind KMoreTools was to point the user at external tools for a given job. It provides a rather complex framework for that, including suggesting not-yet-installed tools. The UX behind that isn't great though, which somewhat deep menu hierarchies and a somewhat arbitrary list of tools. Most KDE apps have moved away from it, with only Dolphin remaining. Instead provide direct integration with relevant KDE tools (Filelight, KDiskFree, KFind) 2023-07-05T07:59:18Z Friedrich W. H. Kossebau kossebau@kde.org 2023-07-04T20:07:48Z urn:sha1:ed2d352c42a6d517d4f29b3582c0e00aa34fe647 * speeds up incremental builds as changes to a header will not always need the full mocs_compilation.cpp for all the target's headers rebuild, while having a moc file sourced into a source file only adds minor extra costs, due to small own code and the used headers usually already covered by the source file, being for the same class/struct * seems to not slow down clean builds, due to empty mocs_compilation.cpp resulting in those quickly processed, while the minor extra cost of the sourced moc files does not outweigh that in summary. Measured times actually improved by some percent points. (ideally CMake would just skip empty mocs_compilation.cpp & its object file one day) * enables compiler to see all methods of a class in same compilation unit to do some sanity checks * potentially more inlining in general, due to more in the compilation unit * allows to keep using more forward declarations in the header, as with the moc code being sourced into the cpp file there definitions can be ensured and often are already for the needs of the normal class methods