Patched KDE Dolphin with Pixel Scaling https://fiftyfourth.xyz/git/dolphin/atom?h=pixelated-scaling-option 2025-04-19T12:32:25Z 2025-04-19T12:32:25Z Felix Ernst felixernst@kde.org 2025-04-19T12:32:25Z urn:sha1:b889a446bfe851a7f49821d469c5f3041b6e5774 The menu for installing and launching Filelight was only available through the status bar free space info button until now. By default we do no longer show the free space info button because the status bar has been changed to show less information by default. This commit adds the "Manage Disk Space Usage" menu to the "Tools" menu in the menu bar so it is more discoverable for users. 2024-11-12T10:54:25Z Felix Ernst felixernst@zohomail.eu 2024-11-10T15:47:19Z urn:sha1:6c73f7912b6fb0327b9fd0ca7a3fff3b2fb4d5e9 Prior to this commit, when Dolphin was opening in a directory for which the free space information cannot be retrieved, the free space info in the status bar would still briefly be visible before hiding for good. This commit avoids this flickering by keeping the space info hidden until space info has been successfully retrieved. There is no use showing an empty/wrong space info before that anyway. I assume the error in the previous code was that it assumed that one could prevent a widget from being shown by overriding QWidget::showEvent(). This does not work because this method is only called to notify QWidgets of their state change. This commit was primarily written because the brief showing of an empty space info was messing with automatic tests. 2024-07-08T11:41:56Z Felix Ernst felixernst@kde.org 2024-07-08T11:41:56Z urn:sha1:0d981e7b7df266c867004e23a169ba8cc13c8683 Before this commit pressing the free space button when Filelight is not installed would show a singular action called "Install Filelight to View Disk Usage Statistics…". Pressing this button would open the store page for Filelight. This is an okay user experience, but we can do better. This commit makes it so pressing the free space button when Filelight is not installed shows an attractive UI that makes clear that freeing up disk space can be accomplished nicely by installing Filelight. The "Install Filelight…" button on this UI is connected to PackageKit directly, so we do not need to show a separate store like Discover and instead trigger an installation right then and there. For this, the recently introduced DolphinPackageInstaller KJob is used. Installation progress is reported through the status bar similar to the progress reporting of slowly loading directories or searches. Installation failure or success is ultimately shown within Dolphin as a passive notification above the view. On Microsoft Windows or when PackageKit is not available, the install button will only open a store page for Filelight. CCBUG: 477739 2023-11-24T11:52:54Z Felix Ernst felixernst@zohomail.eu 2023-11-24T11:18:19Z urn:sha1:139c729b4ab5d0611469f1725468276adcf21f78 This is to make sure that when the window is resized it is less likely that the places panel will be resized only because the status bar doesn't want to become very narrow in width. 2023-11-24T11:52:54Z Felix Ernst felixernst@zohomail.eu 2023-11-18T11:31:00Z urn:sha1:d3637f380ccca26a281331a02ce76ed60e84cfe3 The usage of a label to show this space information is problematic because there are features/actions hidden behind clicking the label. A button makes this clear. It also fixes the accessibility of this control because previously this info would never be read out by screen readers as it couldn't get keyboard focus. A side-effect of this change is that the free disk space bar looks more normal with non-Breeze styles. This had been a long-standing issue. 2023-02-05T05:45:38Z Serg Podtynnyi serg@podtynnyi.com 2023-02-03T17:14:53Z urn:sha1:38c34eeca315c7be58e65d4d3fb72aaf7b866719 2021-02-09T20:39:50Z Nicolas Fella nicolas.fella@gmx.de 2021-02-08T22:09:59Z urn:sha1:f65b0899c3666561cafac14f67ab0bb8a5bfa00a 2020-08-25T17:07:38Z Elvis Angelaccio elvis.angelaccio@kde.org 2020-08-25T17:07:38Z urn:sha1:954e8c47906c12edaaf6e6aebdd41516eceb0d44 Unfortunately licensedigger does not strip the trailing * characters. While at it, use a common style for all source files. 2020-06-08T05:49:45Z Méven Car meven29@gmail.com 2020-05-12T06:26:11Z urn:sha1:bf4388c75525cffd150a51e6c4e0455f60db520f Summary: BUG: 420027 BUG: 422226 FIXED-IN: 20.08 Test Plan: {F8312398} Reviewers: #dolphin, ngraham, broulik, #vdg, elvisangelaccio Reviewed By: #dolphin, ngraham, #vdg, elvisangelaccio Subscribers: elvisangelaccio, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D29213 2018-09-19T08:20:14Z Kai Uwe Broulik kde@privat.broulik.de 2018-09-19T08:20:14Z urn:sha1:391006130e31b80ecc55343f44bddaf06951c90f When explicitly refreshing the view (e.g. F5) also refresh disk space info. This would also allow us to raise the refresh interval somewhat. CCBUG: 398612 Differential Revision: https://phabricator.kde.org/D15508