Patched KDE Dolphin with Pixel Scaling https://fiftyfourth.xyz/git/dolphin/atom?h=pixelated-scaling-option 2025-04-07T21:09:00Z 2025-04-07T21:09:00Z Felix Ernst felixernst@kde.org 2025-04-07T21:09:00Z urn:sha1:4102ccb80457eea44ea280f0ace2a419602bc34b This huge commit is a nearly complete rewrite of the Dolphin search code. It implements most of the improved Dolphin search UI/UX as designed and discussed in a collaborative effort by Kristen McWilliam, Jin Liu, Andy Betts, Tagwerk, a few others and me. See https://invent.kde.org/system/dolphin/-/issues/46. # Notable changes - A toggle to change the search tool is provided as most contributors deemed that useful in https://invent.kde.org/system/dolphin/-/merge_requests/642#note_985112. - The default search is changed to filenamesearch for maximum reliability. - Removing all search parameters will take users back to the view state prior to starting a search instead of keeping the search results open. - The UI for choosing file types or modification dates has been made more powerful with more granularity and more options. - Most search parameters can be configured from a popup menu which gives us extra space for extra clarity. - Labels and help buttons as well as hyperlinks to settings makes sure the user always knows why some search parameters are unavailable in some contexts. - Chips show important search parameters while the popup is closed. They allow quickly removing filters. - The titles of the search and the input field placeholder message change to make clear whether file names or file contents are searched. - When the user actively switches the search tool, whether content should be searched, or whether to search everywhere, this is preserved for the initial state of the search bar when the user opens it the next time after restarting Dolphin. # Architecture - The new DolphinQuery class is independent of the UI and contains all search parameters modifiable in Dolphin as easy setters and getters. - DolphinQuery objects are also used to update the states of every component in the search UI. There is now a clear separation of UI and search configuration/DolphinQuery. - DolphinQuery is responsible for exporting to and importing from search URLs. - The search UI always reflects the currently configured DolphinQuery no matter if the user changed the UI to change the DolphinQuery or loaded a DolphinQuery/older search URL which then is reflected in the UI. - I tried to simplify all classes and their interaction between each other as much as possible. - I added some tests BUG: 386754 CCBUG: 435119 CCBUG: 458761 BUG: 446387 BUG: 470136 CCBUG: 471556 CCBUG: 475439 CCBUG: 477969 BUG: 480001 BUG: 483578 BUG: 488047 BUG: 488845 BUG: 500103 FIXED-IN: 25.08 2024-10-27T17:20:40Z Méven Car meven@kde.org 2024-10-27T17:20:40Z urn:sha1:fdf854bd81d9e42df2d8672d49a0b7fcdb7443a5 Existing settings are converted. Works on most FS except FAT/exFAT which fallback to .directory files. If the extended file attributes (in ADS in Windows) can't be saved, they are saved to file as before. BUG: 322922 You can see file xattr using for instance for Unix filesystems: getfattr -d /home/meven 2023-12-27T10:56:54Z Albert Astals Cid aacid@kde.org 2023-12-27T10:46:22Z urn:sha1:792a92befe48c9c5616ec3b578ada8b57195306f Proposed by krop on #kde-devel Unless my bisect skills failed broken by https://gitlab.kitware.com/cmake/cmake/-/commit/ebc9e448b38378cc21a6b77df03a77d9732c24ac 2023-11-08T09:20:24Z Laurent Montel montel@kde.org 2023-11-08T06:23:16Z urn:sha1:1cf56b2303fea11a6686b1da6355e113f8ab78b7 Remove qt5 specific cmake code too 2023-06-28T07:49:46Z Méven Car meven@kde.org 2023-06-28T07:49:46Z urn:sha1:cd2e64154fd5446a7e19aff4cb147efe2f2ba31e 2023-05-26T16:10:38Z Méven Car meven.car@kdemail.net 2023-05-26T16:10:38Z urn:sha1:c17e6c8d2b33d6d62df46025b69cb7b401f09f62 CCBUG: 196772 2023-03-04T20:58:48Z Dāvis Mosāns davispuh@gmail.com 2023-02-06T21:42:39Z urn:sha1:6600dc9bdc37db5507899f8576a49d57e76a7fa3 2022-07-07T10:41:39Z Felix Ernst fe.a.ernst@gmail.com 2022-07-07T10:41:39Z urn:sha1:c288a48fdc591bf047e2d66f089bde557d948657 - The first test makes sure that the width of the places panel doesn't change no matter what other panels are shown or hidden. There used to be bugs about this. - The second test is kind of an integration test. It makes sure that the go actions work correctly. On two occasions we had the regression here that after going "Up" in the file system hierarchy the folder one emerged from didn't have keyboard focus which makes peeking into multiple folders tiresome. The test also makes sure that going back and forward works as expected and there are some sanity checks about which go actions are enabled, which items are selected and that using tabs doesn't interfere with any of that. 2022-01-14T07:04:01Z Laurent Montel montel@kde.org 2022-01-14T07:04:01Z urn:sha1:c21a02bcab3e8188c4c9b431cd6b506402d2b87d 2022-01-11T12:43:44Z Kai Uwe Broulik kde@privat.broulik.de 2021-12-16T18:37:39Z urn:sha1:af2baf8047c0f4ca248b22f2c36074ad86a2020e They were used by the custom places panel and are now unused.