Patched KDE Dolphin with Pixel Scaling https://fiftyfourth.xyz/git/dolphin/atom?h=pixelated-scaling-option 2025-09-03T12:04:13Z 2025-09-03T12:04:13Z Kunda Ki luzpaz@pm.me 2025-09-03T12:04:13Z urn:sha1:479ce3a1641398a8506812300834666614013850 Found via `codespell -S "*.desktop,*.po,*.svg,*.xml,./po" -L aparent,childs,goup,lokal` 2025-04-07T21:09:00Z Felix Ernst felixernst@kde.org 2025-04-07T21:09:00Z urn:sha1:4102ccb80457eea44ea280f0ace2a419602bc34b This huge commit is a nearly complete rewrite of the Dolphin search code. It implements most of the improved Dolphin search UI/UX as designed and discussed in a collaborative effort by Kristen McWilliam, Jin Liu, Andy Betts, Tagwerk, a few others and me. See https://invent.kde.org/system/dolphin/-/issues/46. # Notable changes - A toggle to change the search tool is provided as most contributors deemed that useful in https://invent.kde.org/system/dolphin/-/merge_requests/642#note_985112. - The default search is changed to filenamesearch for maximum reliability. - Removing all search parameters will take users back to the view state prior to starting a search instead of keeping the search results open. - The UI for choosing file types or modification dates has been made more powerful with more granularity and more options. - Most search parameters can be configured from a popup menu which gives us extra space for extra clarity. - Labels and help buttons as well as hyperlinks to settings makes sure the user always knows why some search parameters are unavailable in some contexts. - Chips show important search parameters while the popup is closed. They allow quickly removing filters. - The titles of the search and the input field placeholder message change to make clear whether file names or file contents are searched. - When the user actively switches the search tool, whether content should be searched, or whether to search everywhere, this is preserved for the initial state of the search bar when the user opens it the next time after restarting Dolphin. # Architecture - The new DolphinQuery class is independent of the UI and contains all search parameters modifiable in Dolphin as easy setters and getters. - DolphinQuery objects are also used to update the states of every component in the search UI. There is now a clear separation of UI and search configuration/DolphinQuery. - DolphinQuery is responsible for exporting to and importing from search URLs. - The search UI always reflects the currently configured DolphinQuery no matter if the user changed the UI to change the DolphinQuery or loaded a DolphinQuery/older search URL which then is reflected in the UI. - I tried to simplify all classes and their interaction between each other as much as possible. - I added some tests BUG: 386754 CCBUG: 435119 CCBUG: 458761 BUG: 446387 BUG: 470136 CCBUG: 471556 CCBUG: 475439 CCBUG: 477969 BUG: 480001 BUG: 483578 BUG: 488047 BUG: 488845 BUG: 500103 FIXED-IN: 25.08 2023-02-05T05:45:38Z Serg Podtynnyi serg@podtynnyi.com 2023-02-03T17:14:53Z urn:sha1:38c34eeca315c7be58e65d4d3fb72aaf7b866719 2022-02-25T19:23:18Z Ismael Asensio isma.af@gmail.com 2022-02-23T23:49:10Z urn:sha1:c623522ecb82c546fc1dd27b77da7a064e5913f9 2021-03-13T16:18:53Z Elvis Angelaccio elvis.angelaccio@kde.org 2021-03-13T16:18:53Z urn:sha1:ffb80cb00d8fd886051f970b5155a55b1d066fcd 2021-02-09T20:39:50Z Nicolas Fella nicolas.fella@gmx.de 2021-02-08T22:09:59Z urn:sha1:f65b0899c3666561cafac14f67ab0bb8a5bfa00a 2020-08-25T17:07:38Z Elvis Angelaccio elvis.angelaccio@kde.org 2020-08-25T17:07:38Z urn:sha1:954e8c47906c12edaaf6e6aebdd41516eceb0d44 Unfortunately licensedigger does not strip the trailing * characters. While at it, use a common style for all source files. 2020-07-11T18:33:58Z Ismael Asensio isma.af@gmail.com 2020-06-14T11:41:29Z urn:sha1:2fc117703f304ba053e2b58b692609f9632535d7 It allows to start a search from a `tags:/mytag/` view. The use case is to refine a search on additional terms (another tags, ratings, etc) 2020-07-05T17:15:31Z Ismael Asensio isma.af@gmail.com 2020-07-04T14:23:24Z urn:sha1:ee97db4dfc10e87f637d8387fb3f4d3590d95697 The `filename` term in a search query is enclosed into quotes. As the user can have additional quotes in the search term, there were several corner cases where the parsing would fail to correctly split the terms New test cases have been added to cover this possibility Previous tests still passes to avoid regressions BEFORE: ``` (filename/quoted) Compared values are not the same Actual (query.text()): "xyz\"\"" Expected (expectedText): "\"abc xyz\"" (filename/mixed) Compared values are not the same Actual (query.text()): "xyz\" tuv\"" Expected (expectedText): "\"abc xyz\" tuv" (content+filename/quoted) Compared values are not the same Actual (query.text()): "abc xyz xyz\"\"" Expected (expectedText): "abc xyz filename:\"\"abc xyz\"\"" ``` 2020-06-22T12:33:29Z Ismael Asensio isma.af@gmail.com 2020-06-22T12:33:29Z urn:sha1:f57ee4b64d924fca85c6ce0be659cd6235f959a9