dolphin/src/tests, branch pixelated-scaling-optionPatched KDE Dolphin with Pixel Scalinghttps://fiftyfourth.xyz/git/dolphin/atom/src/tests?h=pixelated-scaling-option2026-05-30T08:52:32Zplacespaneltest: implement 8 unittests2026-05-30T08:52:32ZSebastian Englbrechtsebastian.englbrecht@tum.de2026-05-30T08:52:32Zurn:sha1:d56feb8151871065505c83eeaa8bd3d53750af10dolphinmainwindowtest: ensure consistent starting state for places panel tests2026-05-28T11:16:06ZSebastian Englbrechtsebastian.englbrecht@tum.de2026-05-25T11:30:09Zurn:sha1:980d4f71a978e7e437bbe9d0100c095d84a0b4fa
In a fresh test environment there is no saved session, so the places panel may
not be visible. Explicitly show it before testing.
Additionally, focus-related assertions require the window to be the active
window — setFocus() on dock widget contents has no effect on an inactive window.
Replace the weak QTRY_VERIFY_WITH_TIMEOUT(activeWindow() != nullptr, 100) with
requestActivate() + qWaitForWindowActive() to enforce this precondition.
Add REUSE/SPDX compliance headers to all files2026-05-28T08:59:51ZSebastian Englbrechtsebastian.englbrecht@tum.de2026-05-21T17:48:41Zurn:sha1:e343cbdfa52f5ff9b754e863830b08416e321ffd
Dolphin was missing copyright and license information on ~750 files,
which would cause the KDE CI job `gitlab-templates/reuse-lint.yml` to fail.
This commit makes the project fully compliant with REUSE Specification 3.3.
REUSE.toml is used for file categories that cannot carry inline comments
or are managed externally:
- po/**: covered with precedence=aggregate so the bulk declaration
combines with individual translators' existing inline headers
- **/*.kcfg, **/*.kcfgc: KConfigXT schema files, no comment syntax
- doc/*.png: documentation screenshots
- src/icons/*.png: application icons (LGPL-3.0-only OR LicenseRef-KDE-Accepted-LGPL)
- src/**/*.{qrc,rc,desktop,xml,json,knsrc,upd,in}: resource and
metadata files without usable comment syntax
- .gitignore, .git-blame-ignore-revs: infrastructure, CC0-1.0
- logo.png: application artwork (LGPL-3.0-only OR LicenseRef-KDE-Accepted-LGPL)
Inline SPDX headers are added to all source files that support comments
(C++, QML, CMake, shell scripts, Python). A small number of remaining
binary or single-purpose files retain individual .license sidecars.
License inference heuristic (applied per file, in order):
1. Existing inline SPDX-License-Identifier — reused as-is
2. Most common license among sibling files in the same directory
that already carry SPDX info, excluding infrastructure filenames
(.gitignore etc.) and requiring at least two qualifying neighbors
to prevent a single CC0 CI config from pulling source files along
3. Default: GPL-2.0-or-later
Copyright years and authors are sourced from `git log --follow` per
file. Automation accounts (l10n daemon scripty@kde.org, Weblate) are
excluded from author lists. If more than 5 authors are found only a
generic KDE Contributors was used.
kitemlistcontrollertest: fix memory leaks2026-05-28T08:59:00ZSebastian Englbrechtsebastian.englbrecht@tum.de2026-05-23T13:29:20Zurn:sha1:3efeaaffd4cb13168e9327ec146f0a40ff9d75afkitemlistcontrollertest: add drag-move hover signal tests2026-05-28T08:55:39ZSebastian Englbrechtsebastian.englbrecht@tum.de2026-05-27T17:22:30Zurn:sha1:e18a5136e557d91ab46368228e3de698a98aa009
Two tests via new simulateDragMove/simulateDragLeave helpers:
- testDragMoveHoverIdempotency: repeated drag-move over the same item
must not emit itemHovered more than once; moving to a different item
must emit itemUnhovered/itemHovered exactly once each.
- testDragLeaveHoverCleanup: dragLeaveEvent must emit itemUnhovered for
the currently hovered item and nothing when no item is hovered.
tests: create smoke test for dolphin2026-05-28T08:12:53ZSebastian Englbrechtsebastian.englbrecht@tum.de2026-05-23T13:30:30Zurn:sha1:1330df1053a9ee9927dc27e1f333a67965dbf02etests: add ctest lint rule forbidding bare QTest::qWait()2026-05-25T11:05:50ZSebastian Englbrechtsebastian.englbrecht@tum.de2026-05-23T11:28:32Zurn:sha1:a33d65a418bf5bdb13d83281ce665d630a95668e
Bare qWait(N) calls in tests are easy to reintroduce inadvertently.
Add a ctest check that greps test sources for qWait() and fails if
any call is found without an // UNAVOIDABLE: comment on the same line.
The error message explains why the pattern is forbidden, lists the
signal-based alternatives, and shows how to suppress the check for
the rare cases where no signal or pollable condition exists.
tests: replace QTest::qWait(N) with signal-based waits2026-05-25T11:05:50ZSebastian Englbrechtsebastian.englbrecht@tum.de2026-05-23T11:27:36Zurn:sha1:22d65e047ac75fc3527ddac2401e90a2805a6f04
Fixed-time sleeps are a source of intermittent failures on slow CI
machines — if the delay is too short, the test races ahead of the
code under test.
Replacements made:
- dolphinmainwindowtest: qWait() calls replaced with QTRY_COMPARE,
QTRY_VERIFY, qWaitFor lambdas and processEvents() where animations
are disabled; one genuinely unavoidable timer wait marked
// UNAVOIDABLE:
- kitemlistcontrollerexpandtest: qWaitFor(..., 100ms) / qWaitFor(...,
300ms) replaced with spy->wait() loops that block until all
expected directoryLoadingCompleted signals have arrived
- kitemlistkeyboardsearchmanagertest: timer-driven wait marked
// UNAVOIDABLE: (must wait for keyboard search timeout to expire)
Add testhelpers.h providing TestHelpers::disableAnimations(), which
eliminates the need for delays that previously waited for Qt UI
animations to settle.
viewproperties: fall back to .directory when xattr space is exhausted2026-05-24T15:27:40ZSebastian Englbrechtsebastian.englbrecht@tum.de2026-05-23T11:27:54Zurn:sha1:1a813b8834f06c4b3a03fb5519cd72c713fd4cf7
When saving view properties to extended attributes failed with NoSpace,
the code cleared the xattr entry and returned without writing anything
to disk. The .directory fallback file was never created, silently
losing the user's view settings.
Fix by copying the current settings into a file-backed KConfig pointing
to .directory whenever the xattr write returns NoSpace. The copy uses
KConfigGroup::copyTo per group (not KConfig::copyFrom, which replaces
the entire entry map) so that unrelated groups already present in
.directory — such as a [Desktop Entry] group carrying a custom folder
icon — are left untouched by sync().
viewproperties: respect saved properties for special folders with global view props enabled2026-05-23T10:25:19ZPan Zhangzhangpan@kylinos.cn2026-05-23T10:25:19Zurn:sha1:2e665e1b513b3f7c082bedc8faaf47bee8008c73
When "Use common display style for all folders" is enabled, the useDefaultSettings condition was always true because useGlobalViewProps was the first term in the OR chain. This caused special folders controlled by useSearchView, useTrashView, and useRecentDocumentsView to reset to their default view on every load, overriding any user customization.
Restrict the unconditional default-apply to non-special folders only. For special folders, the existing timestamp-based check handles the logic correctly, and the fallback in the else branch still applies defaults when no saved properties exist (first visit).
BUG: 520089