dolphin/src/views/draganddrophelper.cpp, branch masterPatched KDE Dolphin with Pixel Scaling
https://fiftyfourth.xyz/git/dolphin/atom?h=master2026-02-15T10:22:01Zdolphinview: indicate drops from Places view2026-02-15T10:22:01ZRafał Lichwałarafal@siliconet.pl2026-02-13T16:10:05Zurn:sha1:aa229c536b84d120e0b74661db10044f64d5a5b2
This commit corrects previous attempt of bug fix done in
https://invent.kde.org/frameworks/kio/-/commit/71b2b38b0c4fc4c7820fd95b031413d854d8f8c6?merge_request_iid=2074
which incorrectly recognized drop action from Places View (based only
on missing Qt::MoveAction which had side effects described in BUG 514697)
This time DolphinView indicates that the given dropEvent
comes from Places View so we must avoid potentially destructive
Move-like plugins actions. This is done by setting proper
KIO::DropJobFlags additional flag for KIO::drop().
CCBUG: 509231
CCBUG: 514697
DragAndDropHelper: Remove check for acceptable drop2026-02-01T17:59:23ZKai Uwe Broulikkde@privat.broulik.de2026-01-29T16:46:32Zurn:sha1:a7406506245c8cd8f7a219492785db7709cff2de
The mentioned Qt Wayland fix that makes us properly reject drops has
long been released by now.
Support drop onto executable to run it2026-02-01T17:33:06ZKai Uwe Broulikkde@privat.broulik.de2026-01-29T16:20:21Zurn:sha1:7d0bbe06dc6e3f69144a5a2c4c697e2d8d0681ec
We already support dropping onto desktop files.
This is also something that KDirOperator did but Dolphin does not.
Revert "DragAndDropHelper::updateDropAction: use StatJob for remote URLs"2024-07-01T14:06:01ZFelix Ernstfelixernst@zohomail.eu2024-06-26T10:45:48Zurn:sha1:e2f316578909e4c886430110808d4681997b3cb7
This reverts commit dc149ec5e52f52c514cf362603d05ba8eea506b8.
This prevents a crash. One issue identified is that the commit that
I am reverting here accesses a QDropEvent at a moment in time in
which it might have already been deleted. We cannot check if it
exists by that time because we do not control its lifetime and it
is not a QObject.
DragAndDropHelper::updateDropAction: use StatJob for remote URLs2024-02-29T23:13:47ZJin Lium.liu.jin@gmail.com2024-02-29T23:13:47Zurn:sha1:dc149ec5e52f52c514cf362603d05ba8eea506b8
When dragging onto tabs/Places from a remote URL, we don't process
the QDropEvent immediately, but start a StatJob and process the
event when it finishes.
Also, the result of the StatJob is cached for 30 seconds, to avoid
starting duplicate jobs.
Fix: can't drop into remote dir2024-02-27T02:13:21ZJin Lium.liu.jin@gmail.com2024-02-20T12:09:26Zurn:sha1:0eed595268d2b0478eee1d5bf5ed6bbd100cdf4c
KFileItem::isDir() only works when it's created from listDir(),
or from a local QUrl. For a remote QUrl, isDir always returns
false, so we can't use that in supportsDropping().
As a workaround, now supportsDropping() always returns true in
remote dirs -- we don't check if a remote dir is writable when
dropping.
Improve DnD handling in read-only dirs2024-02-17T11:14:46ZJin Lium.liu.jin@gmail.com2024-02-17T11:14:46Zurn:sha1:c9c3531c0b6da07de8f90761a3d799ace62f8e89
1. Places panel and tabbar update drag status in read-only dir
2. Don't create drop job in readonly directories
Fix issues if QT_NO_CAST_FROM_ASCII is defined2023-12-25T10:28:58ZMarius Pnmariusp1@gmail.com2023-12-24T06:20:40Zurn:sha1:b2defa2f98468fcb9491ef7c3b96e340bb6bfa92
Fix issues e.g. "error: ‘QString::QString(const QByteArray&)’
is private within this context".
Add clang-format and format code as in Frameworks2023-02-05T05:45:38ZSerg Podtynnyiserg@podtynnyi.com2023-02-03T17:14:53Zurn:sha1:38c34eeca315c7be58e65d4d3fb72aaf7b866719[Places Panel] Support drag and drop from Ark2022-04-11T16:01:51ZKai Uwe Broulikkde@privat.broulik.de2022-04-07T19:41:43Zurn:sha1:0c7f7c92ed961ce46a7b42aeeb1c30070c95ae17
Accepts Ark's special dnd mime types so that archive contents can
be dragged onto a place to extract and/or (mount and) switch to the
hovered location.