dolphin/src/views/draganddrophelper.h, branch pixelated-scaling-optionPatched KDE Dolphin with Pixel Scaling
https://fiftyfourth.xyz/git/dolphin/atom?h=pixelated-scaling-option2026-02-15T10:22:01Zdolphinview: indicate drops from Places view2026-02-15T10:22:01ZRafał Lichwałarafal@siliconet.pl2026-02-13T16:10:05Zurn:sha1:aa229c536b84d120e0b74661db10044f64d5a5b2
This commit corrects previous attempt of bug fix done in
https://invent.kde.org/frameworks/kio/-/commit/71b2b38b0c4fc4c7820fd95b031413d854d8f8c6?merge_request_iid=2074
which incorrectly recognized drop action from Places View (based only
on missing Qt::MoveAction which had side effects described in BUG 514697)
This time DolphinView indicates that the given dropEvent
comes from Places View so we must avoid potentially destructive
Move-like plugins actions. This is done by setting proper
KIO::DropJobFlags additional flag for KIO::drop().
CCBUG: 509231
CCBUG: 514697
Revert "DragAndDropHelper::updateDropAction: use StatJob for remote URLs"2024-07-01T14:06:01ZFelix Ernstfelixernst@zohomail.eu2024-06-26T10:45:48Zurn:sha1:e2f316578909e4c886430110808d4681997b3cb7
This reverts commit dc149ec5e52f52c514cf362603d05ba8eea506b8.
This prevents a crash. One issue identified is that the commit that
I am reverting here accesses a QDropEvent at a moment in time in
which it might have already been deleted. We cannot check if it
exists by that time because we do not control its lifetime and it
is not a QObject.
DragAndDropHelper::updateDropAction: use StatJob for remote URLs2024-02-29T23:13:47ZJin Lium.liu.jin@gmail.com2024-02-29T23:13:47Zurn:sha1:dc149ec5e52f52c514cf362603d05ba8eea506b8
When dragging onto tabs/Places from a remote URL, we don't process
the QDropEvent immediately, but start a StatJob and process the
event when it finishes.
Also, the result of the StatJob is cached for 30 seconds, to avoid
starting duplicate jobs.
Fix: can't drop into remote dir2024-02-27T02:13:21ZJin Lium.liu.jin@gmail.com2024-02-20T12:09:26Zurn:sha1:0eed595268d2b0478eee1d5bf5ed6bbd100cdf4c
KFileItem::isDir() only works when it's created from listDir(),
or from a local QUrl. For a remote QUrl, isDir always returns
false, so we can't use that in supportsDropping().
As a workaround, now supportsDropping() always returns true in
remote dirs -- we don't check if a remote dir is writable when
dropping.
Improve DnD handling in read-only dirs2024-02-17T11:14:46ZJin Lium.liu.jin@gmail.com2024-02-17T11:14:46Zurn:sha1:c9c3531c0b6da07de8f90761a3d799ace62f8e89
1. Places panel and tabbar update drag status in read-only dir
2. Don't create drop job in readonly directories
Add clang-format and format code as in Frameworks2023-02-05T05:45:38ZSerg Podtynnyiserg@podtynnyi.com2023-02-03T17:14:53Zurn:sha1:38c34eeca315c7be58e65d4d3fb72aaf7b866719[Places Panel] Support drag and drop from Ark2022-04-11T16:01:51ZKai Uwe Broulikkde@privat.broulik.de2022-04-07T19:41:43Zurn:sha1:0c7f7c92ed961ce46a7b42aeeb1c30070c95ae17
Accepts Ark's special dnd mime types so that archive contents can
be dragged onto a place to extract and/or (mount and) switch to the
hovered location.
Output of licensedigger + manual cleanup afterwards.2020-08-25T17:07:38ZElvis Angelaccioelvis.angelaccio@kde.org2020-08-25T17:07:38Zurn:sha1:954e8c47906c12edaaf6e6aebdd41516eceb0d44
Unfortunately licensedigger does not strip the trailing * characters.
While at it, use a common style for all source files.
Remove unused #include2018-03-04T18:00:47ZRoman Inflianskasinfroma@gmail.com2018-03-04T13:38:16Zurn:sha1:48b58f830a585b773435c9af5ee2fe8f0c7c641d
Summary: I used CLion inspection to hunt all unused #include
Reviewers: #dolphin, elvisangelaccio, markg
Reviewed By: #dolphin, elvisangelaccio, markg
Subscribers: bcooksley, markg, elvisangelaccio, #dolphin
Differential Revision: https://phabricator.kde.org/D10985
Faster drag&drop in directories with thousands of files2018-02-05T18:25:44ZJaime Torresjtamate@gmail.com2018-02-04T20:19:33Zurn:sha1:9fbf7a0b624aee6b116efdf69462e73f0275fab6
Summary:
The check is called when the mouse is moved in a drag&drop operation.
Dragging all files in a directory with 3000 files under callgrind,
moving the mouse to the other panel and then canceling, doing it twice,
callgrind shows that the method urlListMatchesUrl is called around
200 times, spending around 9,30% of the cpu in those calls.
Applying the patch, callgrind tells it uses now 0.31% of the cpu in 1208 calls.
CCBUG: 342056
Reviewers: #dolphin, elvisangelaccio, markg
Reviewed By: #dolphin, elvisangelaccio, markg
Subscribers: markg, anthonyfieroni, michaelh, elvisangelaccio, ngraham
Differential Revision: https://phabricator.kde.org/D10085