Patched KDE Dolphin with Pixel Scaling https://fiftyfourth.xyz/git/dolphin/atom?h=master 2020-01-11T20:21:52Z 2020-01-11T20:21:52Z Nate Graham nate@kde.org 2020-01-11T20:21:52Z urn:sha1:09e215be4648a96e2daa5a9e5b6adc34ab444f16 This reverts commit 41105103b063c2e538bf0071e54fd429a841238b. KIO's version was just bumped to 5.67, so this can land now without breaking the CI. 2020-01-06T21:34:36Z Nate Graham nate@kde.org 2020-01-06T21:34:36Z urn:sha1:41105103b063c2e538bf0071e54fd429a841238b This reverts commit bae6620f22d29f8e42e38f4dff3df3e44b3f639a. Frameworks 5.67 doesn't exist yet; this needs to wait another month. 2020-01-06T21:25:44Z Nate Graham nate@kde.org 2020-01-02T18:17:18Z urn:sha1:bae6620f22d29f8e42e38f4dff3df3e44b3f639a Summary: With the rename dialog upstreamed in D17595, we can use it from there. This will require the KF5 dep to be bumped to 5.67, which should be feasible given that we're at the very beginning of a new Applications cycle. Depends on D17595 Test Plan: 1. Dolphin Settings > uncheck "rename inline" 2. Rename one or more files. Observe that it still works Tests still pass. Reviewers: #dolphin, elvisangelaccio, meven Reviewed By: elvisangelaccio, meven Subscribers: meven, broulik, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D17597 2019-09-08T07:33:41Z Laurent Montel montel@kde.org 2019-09-08T07:33:41Z urn:sha1:81065795b78e06ec679ec0589fba7082e777ef2a 2019-02-27T07:59:18Z Laurent Montel montel@kde.org 2019-02-27T07:59:18Z urn:sha1:4315e5c9380e22eed483f00adac3d075369eae49 2018-06-05T20:07:45Z Elvis Angelaccio elvis.angelaccio@kde.org 2018-06-03T16:28:23Z urn:sha1:e308985de4b355e5758c916ba683040f6f394603 Summary: The `RenameDialog::slotResult()` slot is currently never called because the dialog is deleted first, due to the usage of the `WA_DeleteOnClose` attribute. This breaks the scroll-to-renamed-file feature when the inline renaming is disabled. Instead of deleting the dialog on close, we can use `deleteLater()` when we are sure the dialog has actually finished its job, which is when the KIO move job emits the `result` signal. Test Plan: - Disable inline renaming - Rename a file so that it goes out of the view - Check whether the view scrolls to the renamed file. Reviewers: #dolphin, emateli Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D13304 2018-04-05T21:15:50Z Elvis Angelaccio elvis.angelaccio@kde.org 2018-04-05T20:33:34Z urn:sha1:30349ef1bdcae0ed80f47c168d46c15020b927d3 Summary: `m_spinBox` is initialized only when renaming multiple items. This commit restores the single-item rename logic which was wrongly removed by commit c5eb4e31161ccf422. BUG: 392743 FIXED-IN: 18.03.90 Test Plan: Disable inline renaming and try to rename single or multiple items (and also to undo the jobs). Subscribers: #dolphin Differential Revision: https://phabricator.kde.org/D11972 2018-03-04T18:00:47Z Roman Inflianskas infroma@gmail.com 2018-03-04T13:38:16Z urn:sha1:48b58f830a585b773435c9af5ee2fe8f0c7c641d Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985 2018-03-03T14:08:01Z Roman Inflianskas infroma@gmail.com 2018-03-03T07:48:57Z urn:sha1:848abc5922167a467bb73107ee6b72e9af3c8317 Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985 2018-03-03T13:44:29Z Roman Inflianskas infroma@gmail.com 2018-03-03T08:46:14Z urn:sha1:32bd8efc7f08a30622deaa3a80b7b26ceaea9f29 Reviewers: #dolphin, markg Reviewed By: markg Subscribers: markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10986