Patched KDE Dolphin with Pixel Scaling https://fiftyfourth.xyz/git/dolphin/atom?h=master 2020-01-11T20:21:52Z 2020-01-11T20:21:52Z Nate Graham nate@kde.org 2020-01-11T20:21:52Z urn:sha1:09e215be4648a96e2daa5a9e5b6adc34ab444f16 This reverts commit 41105103b063c2e538bf0071e54fd429a841238b. KIO's version was just bumped to 5.67, so this can land now without breaking the CI. 2020-01-06T21:34:36Z Nate Graham nate@kde.org 2020-01-06T21:34:36Z urn:sha1:41105103b063c2e538bf0071e54fd429a841238b This reverts commit bae6620f22d29f8e42e38f4dff3df3e44b3f639a. Frameworks 5.67 doesn't exist yet; this needs to wait another month. 2020-01-06T21:25:44Z Nate Graham nate@kde.org 2020-01-02T18:17:18Z urn:sha1:bae6620f22d29f8e42e38f4dff3df3e44b3f639a Summary: With the rename dialog upstreamed in D17595, we can use it from there. This will require the KF5 dep to be bumped to 5.67, which should be feasible given that we're at the very beginning of a new Applications cycle. Depends on D17595 Test Plan: 1. Dolphin Settings > uncheck "rename inline" 2. Rename one or more files. Observe that it still works Tests still pass. Reviewers: #dolphin, elvisangelaccio, meven Reviewed By: elvisangelaccio, meven Subscribers: meven, broulik, kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D17597 2018-06-05T20:07:45Z Elvis Angelaccio elvis.angelaccio@kde.org 2018-06-03T16:28:23Z urn:sha1:e308985de4b355e5758c916ba683040f6f394603 Summary: The `RenameDialog::slotResult()` slot is currently never called because the dialog is deleted first, due to the usage of the `WA_DeleteOnClose` attribute. This breaks the scroll-to-renamed-file feature when the inline renaming is disabled. Instead of deleting the dialog on close, we can use `deleteLater()` when we are sure the dialog has actually finished its job, which is when the KIO move job emits the `result` signal. Test Plan: - Disable inline renaming - Rename a file so that it goes out of the view - Check whether the view scrolls to the renamed file. Reviewers: #dolphin, emateli Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D13304 2018-03-04T18:00:47Z Roman Inflianskas infroma@gmail.com 2018-03-04T13:38:16Z urn:sha1:48b58f830a585b773435c9af5ee2fe8f0c7c641d Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985 2018-01-27T11:51:30Z Chinmoy Ranjan Pradhan chinmoyrp65@gmail.com 2018-01-27T11:49:39Z urn:sha1:c5eb4e31161ccf422a2f2492fe998c5c9817bea4 Summary: Use KIO::BatchRenameJob in Dolphin::RenameDialog to rename multiple files. With this viewing progress of rename operation and undo is possible. See D9103 and D9107. Reviewers: #dolphin, elvisangelaccio Subscribers: elvisangelaccio, ngraham, broulik Differential Revision: https://phabricator.kde.org/D9836 2017-11-20T22:25:48Z Kevin Funk kfunk@kde.org 2017-11-20T22:25:06Z urn:sha1:464b13f3828e5cdd03438d0881c3a62c7cda6333 Also use override instead of Q_DECL_OVERRIDE 2017-09-17T09:12:46Z Emirald Mateli aldo.mateli@gmail.com 2017-09-17T09:07:44Z urn:sha1:478f404b8abf924a0e3e21bbf1dd49aefbe47672 When renaming a file, if its new name causes it to scroll out of view, Dolphin will not scroll to the location of the new file. This patch aims to address that. This affects all view modes. CCBUG: 354330 Test Plan: 1. Have many files in a directory (or several files, just zoom in a lot) 2. Rename a file so that it will move out of view Differential Revision: https://phabricator.kde.org/D6312 2015-09-07T20:58:38Z Emmanuel Pescosta emmanuelpescosta099@gmail.com 2015-09-06T14:34:41Z urn:sha1:4143a69c05be6da8a91c8ba0db505a47b22ddc75 BUG: 351708 FIXED-IN: 15.08.1 REVIEW: 125078 2015-02-25T16:21:10Z Emmanuel Pescosta emmanuelpescosta099@gmail.com 2015-02-25T11:12:55Z urn:sha1:25751088c33ce507096a3e25ee1eeaa7de38c76b REVIEW: 122687