Patched KDE Dolphin with Pixel Scaling https://fiftyfourth.xyz/git/dolphin/atom?h=master 2023-07-05T07:59:18Z 2023-07-05T07:59:18Z Friedrich W. H. Kossebau kossebau@kde.org 2023-07-04T20:07:48Z urn:sha1:ed2d352c42a6d517d4f29b3582c0e00aa34fe647 * speeds up incremental builds as changes to a header will not always need the full mocs_compilation.cpp for all the target's headers rebuild, while having a moc file sourced into a source file only adds minor extra costs, due to small own code and the used headers usually already covered by the source file, being for the same class/struct * seems to not slow down clean builds, due to empty mocs_compilation.cpp resulting in those quickly processed, while the minor extra cost of the sourced moc files does not outweigh that in summary. Measured times actually improved by some percent points. (ideally CMake would just skip empty mocs_compilation.cpp & its object file one day) * enables compiler to see all methods of a class in same compilation unit to do some sanity checks * potentially more inlining in general, due to more in the compilation unit * allows to keep using more forward declarations in the header, as with the moc code being sourced into the cpp file there definitions can be ensured and often are already for the needs of the normal class methods 2023-02-05T05:45:38Z Serg Podtynnyi serg@podtynnyi.com 2023-02-03T17:14:53Z urn:sha1:38c34eeca315c7be58e65d4d3fb72aaf7b866719 2022-06-02T05:55:08Z Laurent Montel montel@kde.org 2022-06-02T05:55:08Z urn:sha1:8df1ea33276f1d6107d6c1b187cd0fdc52bfe31b 2022-05-11T06:18:02Z Laurent Montel montel@kde.org 2022-05-11T06:17:35Z urn:sha1:6a727b1a7d3fb2db91456bbb3ff7fba6e7760353 2021-12-01T22:10:58Z Alexander Lohnau alexander.lohnau@gmx.de 2021-11-11T19:51:00Z urn:sha1:f1756dd1413fa602f536e057087583be2ddbd2b2 As the method impl suggests, the left value is preferred if all the values are the same. This is the case for the given layout. ```cpp int QLayout::margin() const { int left, top, right, bottom; getContentsMargins(&left, &top, &right, &bottom); if (left == top && top == right && right == bottom) { return left; } else { return -1; } } ``` 2020-10-14T23:22:00Z Elvis Angelaccio elvis.angelaccio@kde.org 2020-10-14T21:46:40Z urn:sha1:de6933617868df265f4a6534c764d8b9f7a0825c Quoting from: https://github.com/qt/qtbase/commit/714409b23ce5ec33e56adce5ba1966aad67c3b34 ``` The QLabel changes to the pixmap/picture getters provide the following migration path: QPixmap *ppix = l->pixmap(); // up to 5.15, warns in 5.15 QPixmap pval = l->pixmap(Qt::ReturnByValue); // new in 5.15, works in 6 QPixmap pixmap = l->pixmap(); // from Qt 6 on ``` Since we can't require 5.15 yet in dolphin, the port is done only when building with Qt >= 5.15 2020-08-25T17:07:38Z Elvis Angelaccio elvis.angelaccio@kde.org 2020-08-25T17:07:38Z urn:sha1:954e8c47906c12edaaf6e6aebdd41516eceb0d44 Unfortunately licensedigger does not strip the trailing * characters. While at it, use a common style for all source files. 2018-08-20T23:03:33Z Elvis Angelaccio elvis.angelaccio@kde.org 2018-08-13T21:36:35Z urn:sha1:6674c9c387d0986e99698332727bf797257bf07d Summary: It was only used as fallback when baloo was not found, but `KFileMetaDataWidget` is useless without nepomuk. The result of this patch is that the information panel and the tooltips won't be available from platforms without baloo (instead of being available but broken). The baloo dependency remains optional. Closes T8720 Test Plan: Build dolphin with `cmake -DCMAKE_DISABLE_FIND_PACKAGE_KF5Baloo=ON ..` and make sure it doesn't show tooltips or the information panel. Reviewers: #dolphin, broulik, ngraham Subscribers: kfm-devel Tags: #dolphin Maniphest Tasks: T8720 Differential Revision: https://phabricator.kde.org/D14814 2018-03-04T18:00:47Z Roman Inflianskas infroma@gmail.com 2018-03-04T13:38:16Z urn:sha1:48b58f830a585b773435c9af5ee2fe8f0c7c641d Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985 2018-03-03T14:08:01Z Roman Inflianskas infroma@gmail.com 2018-03-03T07:48:57Z urn:sha1:848abc5922167a467bb73107ee6b72e9af3c8317 Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985