Patched KDE Dolphin with Pixel Scaling https://fiftyfourth.xyz/git/dolphin/atom?h=master 2023-02-05T05:45:38Z 2023-02-05T05:45:38Z Serg Podtynnyi serg@podtynnyi.com 2023-02-03T17:14:53Z urn:sha1:38c34eeca315c7be58e65d4d3fb72aaf7b866719 2022-03-31T12:22:24Z Kai Uwe Broulik kde@privat.broulik.de 2022-03-29T07:36:30Z urn:sha1:64ffcdad4ff60e1f0b443c00229e6aacf523c72f This reverts b7fbd19a7660424e6839df37f12b33111408b1fc but creates the widget only once and then reuses it. However, ownership of a parent-less widget is transferred to the `KToolTipWidget` but since we first request metadata, then show the tooltip (or won't if the mouse moved on since), we cannot rely on the `KToolTipWidget` exclusively. Instead, when we still delete the widget ourself until we have shown the `KToolTipWidget` once at which point it will handle the life time for us. This fixes parenting the widget to `DolphinView` which would make it appear as a broken line in the top left of the window. 2022-03-25T10:18:46Z Nicolas Fella nicolas.fella@gmx.de 2022-03-25T01:36:21Z urn:sha1:b7fbd19a7660424e6839df37f12b33111408b1fc Currently any time we hover the mouse over a file we create a new DolphinFileMetaDataWidget (even when we don't actually show a tooltip). That is quite wasteful Instead we can reuse the existing instance and only change the URL 2021-02-09T20:39:50Z Nicolas Fella nicolas.fella@gmx.de 2021-02-08T22:09:59Z urn:sha1:f65b0899c3666561cafac14f67ab0bb8a5bfa00a 2020-08-25T17:07:38Z Elvis Angelaccio elvis.angelaccio@kde.org 2020-08-25T17:07:38Z urn:sha1:954e8c47906c12edaaf6e6aebdd41516eceb0d44 Unfortunately licensedigger does not strip the trailing * characters. While at it, use a common style for all source files. 2019-08-03T13:29:26Z Piotr Henryk Dabrowski phd@phd.re 2019-08-03T13:28:35Z urn:sha1:ba92917ac2f32e6fa7c8e5c3ecbd6a36b2e79eb0 Summary: Instantly hide tooltip shown over an element when a key is pressed. Currently, when pressing an alphanum key to select a different file, the tooltip continues to cover much of the window - often hiding that newly selected file from view. Reviewers: #dolphin, ngraham, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: broulik, elvisangelaccio, kfm-devel, pdabrowski Tags: #dolphin Differential Revision: https://phabricator.kde.org/D22512 2019-03-17T17:09:02Z David Hallas david@davidhallas.dk 2019-03-13T19:27:40Z urn:sha1:f2b72c164888bce6dcdec343fd832a98f5837be1 Summary: Fix crash at shutdown after showing a tooltip. The commit 94d7e1471e0a81b72285795ad91c4f6196157ae4 introduced a crash that occurs when closing Dolphin after Dolphin has showed a tooltip. This happens because the ToolTipManager::showToolTip function calls the KToopTipWidget::showBelow function passing in the pointer to the DolphinFileMetaDataWidget. But this also passes the ownership of the pointer to the KToopTipWidget as long as a new tooltip is not shown. The problem is that at shutdown, the KToopTipWidget instance will be destoyed first and therefore also destroy the DolphinFileMetaDataWidget instance (which the ToolTipManager still owns through the QScopedPointer) causing it to be deleted twice. The fix for this is simply to swap the order of these two members so that the DolphinFileMetaDataWidget is destroyed first by the QScopedPointer thereby removing it from the KToopTipWidget if it has been set as it's parent. Test Plan: Open Dolphin Show a Tool Tip Close Dolphin Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19737 2019-03-10T16:41:42Z David Hallas david@davidhallas.dk 2019-03-03T06:37:52Z urn:sha1:94d7e1471e0a81b72285795ad91c4f6196157ae4 Summary: Fixes leak of DolphinFileMetaDataWidget in ToolTipManager. The destructor of ToolTipManager failed to delete the m_fileMetaDataWidget member. This is seen at shutdown but also when you close a tab that has displayed a tooltip. Test Plan: Compile Dolphin with address sanitizer Open Dolphin Show a tooltip Close Dolphin Reviewers: #dolphin, elvisangelaccio Reviewed By: #dolphin, elvisangelaccio Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D19485 2018-03-04T18:00:47Z Roman Inflianskas infroma@gmail.com 2018-03-04T13:38:16Z urn:sha1:48b58f830a585b773435c9af5ee2fe8f0c7c641d Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985 2017-11-20T22:25:48Z Kevin Funk kfunk@kde.org 2017-11-20T22:25:06Z urn:sha1:464b13f3828e5cdd03438d0881c3a62c7cda6333 Also use override instead of Q_DECL_OVERRIDE