dolphin/src/views/versioncontrol/updateitemstatesthread.cpp, branch pixelated-scaling-optionPatched KDE Dolphin with Pixel Scaling
https://fiftyfourth.xyz/git/dolphin/atom?h=pixelated-scaling-option2026-01-22T15:14:16Zclang-tidy: use default for trivial constructor2026-01-22T15:14:16ZMéven Carmeven@kde.org2026-01-22T15:04:09Zurn:sha1:174bc684603326de15e933b3bb24ffb739f3291eversioncontrol: make observer the sole owner of plugins2024-04-04T11:39:47ZMéven Carmeven@kde.org2024-03-30T09:55:15Zurn:sha1:b9024361fa922d9cd423aa05721a337a59b98229
Also properly shutdown thread.
versioncontrol: Prevent a use-after-free in UpdateItemStatesThread2024-03-24T10:55:54ZMéven Carmeven@kde.org2024-03-23T10:55:37Zurn:sha1:d270700c0ef42b6f1e1bef09bbf0bab59b3e78d1
UpdateItemStatesThread kept a pointer reference to m_plugin whose
lifetime was tied to VersionControlObserver parents.
On application shutdown it could happen the thread is still running when
the Observer is destroyed.
Make the plugin pointer a weak reference, allowing to stop the thread
when the plugin is gone.
BUG: 477425
Add explicit moc includes to sources for moc-covered headers2023-07-05T07:59:18ZFriedrich W. H. Kossebaukossebau@kde.org2023-07-04T20:07:48Zurn:sha1:ed2d352c42a6d517d4f29b3582c0e00aa34fe647
* speeds up incremental builds as changes to a header will not always
need the full mocs_compilation.cpp for all the target's headers rebuild,
while having a moc file sourced into a source file only adds minor
extra costs, due to small own code and the used headers usually
already covered by the source file, being for the same class/struct
* seems to not slow down clean builds, due to empty mocs_compilation.cpp
resulting in those quickly processed, while the minor extra cost of the
sourced moc files does not outweigh that in summary.
Measured times actually improved by some percent points.
(ideally CMake would just skip empty mocs_compilation.cpp & its object
file one day)
* enables compiler to see all methods of a class in same compilation unit
to do some sanity checks
* potentially more inlining in general, due to more in the compilation unit
* allows to keep using more forward declarations in the header, as with the
moc code being sourced into the cpp file there definitions can be ensured
and often are already for the needs of the normal class methods
Add clang-format and format code as in Frameworks2023-02-05T05:45:38ZSerg Podtynnyiserg@podtynnyi.com2023-02-03T17:14:53Zurn:sha1:38c34eeca315c7be58e65d4d3fb72aaf7b866719Output of licensedigger + manual cleanup afterwards.2020-08-25T17:07:38ZElvis Angelaccioelvis.angelaccio@kde.org2020-08-25T17:07:38Zurn:sha1:954e8c47906c12edaaf6e6aebdd41516eceb0d44
Unfortunately licensedigger does not strip the trailing * characters.
While at it, use a common style for all source files.
Remove unused #include2018-03-03T14:08:01ZRoman Inflianskasinfroma@gmail.com2018-03-03T07:48:57Zurn:sha1:848abc5922167a467bb73107ee6b72e9af3c8317
Summary: I used CLion inspection to hunt all unused #include
Reviewers: #dolphin, elvisangelaccio, markg
Reviewed By: #dolphin, elvisangelaccio, markg
Subscribers: markg, elvisangelaccio, #dolphin
Differential Revision: https://phabricator.kde.org/D10985
Modernize: Use nullptr everywhere2017-11-21T09:53:12ZKevin Funkkfunk@kde.org2017-11-21T09:52:14Zurn:sha1:a6db5029acc09639fd8c7c20a7676b1ac9f36539Move the KVersionControlPlugin2 interface from konqlib to Dolphin and remove the deprecated KVersionControlPlugin interface from konqlib2015-02-25T16:21:10ZEmmanuel Pescostaemmanuelpescosta099@gmail.com2015-02-25T11:12:55Zurn:sha1:25751088c33ce507096a3e25ee1eeaa7de38c76b
REVIEW: 122687
Replaced the ItemState structure with QPair<KFileItem, KVersionControlPlugin2::ItemVersion>2014-10-15T15:42:42ZEmmanuel Pescostaemmanuelpescosta099@gmail.com2014-10-15T15:42:42Zurn:sha1:9c6c0089c945241be8eff7225916f2b54d84c838