dolphin/src/views/versioncontrol/updateitemstatesthread.h, branch master

versioncontrol: Prevent a use-after-free in UpdateItemStatesThread

2024-03-24T10:55:54Z

UpdateItemStatesThread kept a pointer reference to m_plugin whose lifetime was tied to VersionControlObserver parents. On application shutdown it could happen the thread is still running when the Observer is destroyed. Make the plugin pointer a weak reference, allowing to stop the thread when the plugin is gone. BUG: 477425

Add clang-format and format code as in Frameworks

2023-02-05T05:45:38Z

Output of licensedigger + manual cleanup afterwards.

2020-08-25T17:07:38Z

Unfortunately licensedigger does not strip the trailing * characters. While at it, use a common style for all source files.

Remove unused #include

2018-03-04T18:00:47Z

Summary: I used CLion inspection to hunt all unused #include Reviewers: #dolphin, elvisangelaccio, markg Reviewed By: #dolphin, elvisangelaccio, markg Subscribers: bcooksley, markg, elvisangelaccio, #dolphin Differential Revision: https://phabricator.kde.org/D10985

Modernize: Use override where possible

2017-11-20T22:25:48Z

Also use override instead of Q_DECL_OVERRIDE

Move the KVersionControlPlugin2 interface from konqlib to Dolphin and remove the deprecated KVersionControlPlugin interface from konqlib

2015-02-25T16:21:10Z

REVIEW: 122687

Fix Exports.

2014-11-20T03:06:58Z

REVIEW: 121078

Q_DECL_OVERRIDE

2014-11-03T22:52:18Z

Remove some unused functions.

2014-02-11T19:30:50Z

void KFileItemModel::slotClear(const KUrl& url) bool UpdateItemsThread::lockPlugin() <- Done with QMutexLocker void UpdateItemsThread::unlockPlugin() REVIEW: 115627

Remove the "retrieved items" code from UpdateItemStatesThread and VersionControlObserver.

2014-01-16T11:55:42Z

Showing an error message, makes no sense in this case - the user can see it when all items are "unversioned". The plugins still have the ability to show error/warning messages on real errors. (and only where it makes sense ;) REVIEW: 114992 FIXED-IN: 4.13