dolphin/src, branch pixelated-scaling-optionPatched KDE Dolphin with Pixel Scalinghttps://fiftyfourth.xyz/git/dolphin/atom/src?h=pixelated-scaling-option2026-06-04T21:58:24ZKItemListWidget: bump selection alpha and use Active palette group2026-06-04T21:58:24ZConwayconway@fiftyfourth.xyz2026-05-13T14:48:08Zurn:sha1:4efbed4e6ad8bfd672a87afee8fd2c3bcd5f44cc
Selection background was 0.32 alpha of QPalette::Highlight resolved
against the widget's current palette group. On dark color schemes the
Inactive group sources Highlight from Colors:Window (per KColorScheme's
ChangeSelectionColor effect), so a near-black Window at 0.32 alpha
leaves the selection nearly invisible. Force the Active group so the
scheme's Selection color is used, and raise the alphas (selected
0.32 → 0.70, selected+hovered 0.40 → 0.85, hover-only 0.06 → 0.12) for
adequate contrast on all-dark themes.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Adds options for pixel scaling and filename extensions2026-06-04T21:58:24ZConwayconway@fiftyfourth.xyz2026-05-01T14:25:05Zurn:sha1:36099c98979dfa8533a7b078dee907247a87b718DolphinNavigatorsWidgetAction: Let non-Breeze QStyles style the non-toolbar navbar how they want2026-06-04T08:52:56ZFilip Filafilipfila.kde@gmail.com2026-06-04T08:52:56Zurn:sha1:76f6eb07739290bd7e7a61946f51d7329fb75545
Currently when Dolphin's location bar is moved from the main toolbar, it stops being a nice `FrameLineEdit` that QStyles can style as they please.
That's because the current code is only adjusted for Breeze, which wants to fill the entire navbar frame with a plain rectangle.
Unfortunately, non-Breeze styles suffer from bad looks because this Breeze design is applied for them too.
In order to fix this, this MR restores the styling power back to QStyles by removing the rectangle, all the while keeping it for Breeze.
| Before (Breeze) | After (Breeze) |
| ------ | ------ |
|{width=698 height=134} | {width=715 height=138} |
| Before (Oxygen) | After (Oxygen) |
| ------ | ------ |
| {width=714 height=114} | {width=687 height=129} |
| Before (MSWindows9x) | After (MSWindows9x) |
| ------ | ------ |
| {width=715 height=107} | {width=702 height=100} |
| Before (Darkly) | After (Darkly) |
| ------ | ------ |
| {width=675 height=123} | {width=705 height=144} |
| Before (Fusion) | After (Fusion) |
| ------ | ------ |
| {width=701 height=118} | {width=692 height=122} |
| Before (Kvantum) | After (Kvantum) |
| ------ | ------ |
| {width=697 height=135} | {width=700 height=123} |
BUG: 518285
FIXED-IN:
SVN_SILENT made messages (.desktop file) - always resolve ours2026-06-03T02:24:32Zl10n daemon scriptscripty@kde.org2026-06-03T02:24:32Zurn:sha1:fe6bb8bd6a076d8293e2090935ee41577324c760
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
GIT_SILENT made messages (after extraction)2026-06-03T01:12:18Zl10n daemon scriptscripty@kde.org2026-06-03T01:12:18Zurn:sha1:e402e1211cae466c7ba906dcb9e6337cd33d63bcSVN_SILENT made messages (.desktop file) - always resolve ours2026-06-02T02:07:16Zl10n daemon scriptscripty@kde.org2026-06-02T02:07:16Zurn:sha1:4d74e6555482dc289f5b2c2e1c7c0af2f80399d5
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
kfileitemmodel: prefer prefix over postfix increment for iterator2026-06-01T09:04:16ZSebastian Englbrechtsebastian.englbrecht@tum.de2026-05-31T17:05:52Zurn:sha1:4b68a7ca5ea08df4bc108dfcb645fd8a067df7f2
Postfix increment creates an unnecessary temporary copy.
actionwithwidget: use QPointer::data() for explicit pointer extraction2026-06-01T09:04:16ZSebastian Englbrechtsebastian.englbrecht@tum.de2026-05-31T17:02:09Zurn:sha1:5a562e16806e1335ecc594ec36ef9af12e57c040
Returning a QPointer<T> where T* is expected relies on an implicit
conversion that cppcheck cannot model correctly. Use .data() to make
the intent explicit.
dolphinmainwindow,dolphinview: clarify QPointer semantics around exec()2026-06-01T09:04:16ZSebastian Englbrechtsebastian.englbrecht@tum.de2026-05-31T16:59:36Zurn:sha1:44973c9dd016569e643a73148c32bd1a0b01d71d
exec() runs a nested event loop that can destroy the parent widget, so
the post-exec null-check on the QPointer is intentional, not redundant.
dolphinmainwindow: replace `if (contextMenu) deleteLater()` with
`delete contextMenu`. QPointer returns nullptr for a destroyed object,
making delete a safe no-op.
dolphinview: capture the menu as a raw pointer for pre-exec setup;
reserve the QPointer for the post-exec liveness check and deletion.
dolphinview: Unselect navigator when click on background2026-05-31T08:57:56ZFlorian RICHERflorian.richer@protonmail.com2026-05-15T15:29:46Zurn:sha1:2a72145eb09276a4576762b74cb976fcd4550e87