From 4b68a7ca5ea08df4bc108dfcb645fd8a067df7f2 Mon Sep 17 00:00:00 2001 From: Sebastian Englbrecht Date: Sun, 31 May 2026 19:05:52 +0200 Subject: kfileitemmodel: prefer prefix over postfix increment for iterator Postfix increment creates an unnecessary temporary copy. --- src/kitemviews/kfileitemmodel.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/kitemviews/kfileitemmodel.cpp b/src/kitemviews/kfileitemmodel.cpp index 699ce289c..ba33254c0 100644 --- a/src/kitemviews/kfileitemmodel.cpp +++ b/src/kitemviews/kfileitemmodel.cpp @@ -1155,7 +1155,7 @@ void KFileItemModel::applyFilters() // ===STEP 3=== // Handles the ancestorsOfNewVisibleItems. // Now that we are done iterating through m_filteredItems we can safely move the ancestorsOfNewVisibleItems from m_filteredItems to newVisibleItems. - for (it = ancestorsOfNewVisibleItems.begin(); it != ancestorsOfNewVisibleItems.end(); it++) { + for (it = ancestorsOfNewVisibleItems.begin(); it != ancestorsOfNewVisibleItems.end(); ++it) { if (m_filteredItems.remove(it.key())) { // m_filteredItems still contained this ancestor until now so we can be sure that we aren't adding a duplicate ancestor to newVisibleItems. newVisibleItems.append(it.value()); -- cgit v1.3.1