From cf12c8c61d6b5267b3f5755462f000fa69d9c667 Mon Sep 17 00:00:00 2001 From: Sebastian Englbrecht Date: Tue, 26 May 2026 20:48:03 +0200 Subject: KItemListWidgetCreator, KFileItemModelFilter: delete copy operations Both classes own a raw pointer freed in the destructor. The implicit shallow copy would cause a double-free. Mark copy constructor and operator= as = delete. Found with cppcheck --- src/kitemviews/kitemlistview.h | 3 +++ src/kitemviews/private/kfileitemmodelfilter.h | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/kitemviews/kitemlistview.h b/src/kitemviews/kitemlistview.h index c8ab796a9..8dc83d528 100644 --- a/src/kitemviews/kitemlistview.h +++ b/src/kitemviews/kitemlistview.h @@ -866,6 +866,9 @@ public: KItemListWidgetCreator(); ~KItemListWidgetCreator() override; + KItemListWidgetCreator(const KItemListWidgetCreator &) = delete; + KItemListWidgetCreator &operator=(const KItemListWidgetCreator &) = delete; + KItemListWidget *create(KItemListView *view) override; void calculateItemSizeHints(QVector> &logicalHeightHints, qreal &logicalWidthHint, const KItemListView *view) const override; diff --git a/src/kitemviews/private/kfileitemmodelfilter.h b/src/kitemviews/private/kfileitemmodelfilter.h index 9d93d42cc..4559f880f 100644 --- a/src/kitemviews/private/kfileitemmodelfilter.h +++ b/src/kitemviews/private/kfileitemmodelfilter.h @@ -28,6 +28,9 @@ public: KFileItemModelFilter(); virtual ~KFileItemModelFilter(); + KFileItemModelFilter(const KFileItemModelFilter &) = delete; + KFileItemModelFilter &operator=(const KFileItemModelFilter &) = delete; + /** Filtering modes of KFileItemModelFilter */ enum FilterMode { /** Substring matching. */ -- cgit v1.3.1