From ddfc69105a8e8975a517210116de625c621a6757 Mon Sep 17 00:00:00 2001 From: Méven Car Date: Tue, 10 Mar 2026 11:48:03 +0100 Subject: trashsettingspage: prevent a memleak on exit KCModuleLoader when passed in a parent Widget will add a layout to it. The internal widget is added to it. When we don't pass a parentWidget, this layout leaks. Instead don't add a layout ourselves, let the one in KCModuleLoader do the work. Detected by asan. --- src/settings/trash/trashsettingspage.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/settings/trash/trashsettingspage.cpp b/src/settings/trash/trashsettingspage.cpp index b19571338..7d61a49ce 100644 --- a/src/settings/trash/trashsettingspage.cpp +++ b/src/settings/trash/trashsettingspage.cpp @@ -15,11 +15,7 @@ TrashSettingsPage::TrashSettingsPage(QWidget *parent) : SettingsPageBase(parent) { - QFormLayout *topLayout = new QFormLayout(this); - - m_kcm = KCModuleLoader::loadModule(KPluginMetaData(QStringLiteral("kcm_trash"))); - - topLayout->addRow(m_kcm->widget()); + m_kcm = KCModuleLoader::loadModule(KPluginMetaData(QStringLiteral("kcm_trash")), this); loadSettings(); -- cgit v1.3