From 03aa2029d7c65071d054444c375e2ddb89ea6f12 Mon Sep 17 00:00:00 2001 From: Peter Penz Date: Sun, 4 May 2008 18:24:28 +0000 Subject: Fixed issue that sometimes the dragging from an inactive view to an active view does not work. Note that this is just a workaround, QAbstractItemView should take care about this itself. I tried to provide a Qt-only example for this, but it is more tricky than I thought: it seems some expensive operations are required, so that the position of the second mouse-move event is outside the item area... I'll retest this issue without workaround if Qt 4.4 final is out. BUG: 154619 svn path=/trunk/KDE/kdebase/apps/; revision=803980 --- src/dolphiniconsview.cpp | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) (limited to 'src/dolphiniconsview.cpp') diff --git a/src/dolphiniconsview.cpp b/src/dolphiniconsview.cpp index a9659739a..2e6d7dca6 100644 --- a/src/dolphiniconsview.cpp +++ b/src/dolphiniconsview.cpp @@ -167,7 +167,17 @@ void DolphinIconsView::contextMenuEvent(QContextMenuEvent* event) void DolphinIconsView::mousePressEvent(QMouseEvent* event) { m_controller->requestActivation(); - if (!indexAt(event->pos()).isValid()) { + const QModelIndex index = indexAt(event->pos()); + if (index.isValid() && (event->button() == Qt::LeftButton)) { + // TODO: It should not be necessary to manually set the dragging state, but I could + // not reproduce this issue with a Qt-only example yet to find the root cause. + // Issue description: start Dolphin, split the view and drag an item from the + // inactive view to the active view by a very fast mouse movement. Result: + // the item gets selected instead of being dragged... + setState(QAbstractItemView::DraggingState); + } + + if (!index.isValid()) { const Qt::KeyboardModifiers modifier = QApplication::keyboardModifiers(); if (!(modifier & Qt::ShiftModifier) && !(modifier & Qt::ControlModifier)) { clearSelection(); -- cgit v1.3