From 126c14b3ba6e165e94727b448bdaf1f0c48502f7 Mon Sep 17 00:00:00 2001 From: Rafael Fernández López Date: Sat, 23 Jun 2007 00:43:20 +0000 Subject: Small fixes, but that have an impact of how things are visualized. * Move "not tagged" elements to the end. We sort the rest (when they have tags), but keep untagged elements (the category) at the end of the view, since the user had "less" interest on them. * Break the law again of "dirs first". If we have on a folder only a tagged file (and is a file) and the rest are folders, that file goes first, since it was tagged. * If we are on the same category, dirs go first. Here we make them citizens of first class. * Commas instead of spaces when building categories for tags, they make it more readable and less error-prone (we can have tags "a", "dog" and "a dog" as tags, right?, so spaces here make the thing a bit hard to distinguish, I have two tags "a", "dog", or the tag "a dog") ;) * Return an empty string when the item is not tagged at the method tagsForIndex. This way we always show untagged items the latest ones very easily (without nasty string checks). We will let the categorizer put a fancy name for them, if the returned string was empty. CCMAIL: peter.penz@gmx.at svn path=/trunk/KDE/kdebase/apps/; revision=679097 --- src/dolphinitemcategorizer.cpp | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'src/dolphinitemcategorizer.cpp') diff --git a/src/dolphinitemcategorizer.cpp b/src/dolphinitemcategorizer.cpp index c83f9383f..dfb384062 100644 --- a/src/dolphinitemcategorizer.cpp +++ b/src/dolphinitemcategorizer.cpp @@ -177,6 +177,10 @@ QString DolphinItemCategorizer::categoryForItem(const QModelIndex& index, case DolphinView::SortByTags: { retString = DolphinSortFilterProxyModel::tagsForIndex(index); + + if (retString.isEmpty()) + retString = i18n("Not yet tagged"); + break; } #endif -- cgit v1.3