From f70b85b4ca2b96ebf578d4db790a8ac3f69f766e Mon Sep 17 00:00:00 2001 From: Peter Penz Date: Fri, 15 Feb 2008 23:13:47 +0000 Subject: Initially I thought it's better not having code as default value inside dolphin_generalsettings.kcfg. But the check for an empty home URL in DolphinMainWindow::init() must also be done when invoking GeneralSettings::setDefaults() in StartupSettingsPage, otherwise the home URL would get empty... Using QDir::homePath() as default-value inside the *.kcfg file prevents such issues. CCMAIL: michael.a.oshea@gmail.com svn path=/trunk/KDE/kdebase/apps/; revision=775494 --- src/dolphinmainwindow.cpp | 3 --- 1 file changed, 3 deletions(-) (limited to 'src/dolphinmainwindow.cpp') diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp index d4276d492..dd8b02efb 100644 --- a/src/dolphinmainwindow.cpp +++ b/src/dolphinmainwindow.cpp @@ -614,9 +614,6 @@ void DolphinMainWindow::init() const bool firstRun = generalSettings->firstRun(); if (firstRun) { generalSettings->setViewPropsTimestamp(QDateTime::currentDateTime()); - Q_ASSERT(generalSettings->homeUrl().isEmpty()); - const KUrl homeUrl(QDir::homePath()); - generalSettings->setHomeUrl(homeUrl.prettyUrl()); } setAcceptDrops(true); -- cgit v1.3