From b6fc58c3c32b03f504a5f697b62c4834dc3f650a Mon Sep 17 00:00:00 2001 From: Felix Ernst Date: Wed, 12 Aug 2020 20:45:17 +0200 Subject: Adress the first round of Angelaccio's review comments - Split the viewContainers(bool includeInActive) into two methods without parameters - Prevent users from accidently hiding all Url Navigators by preventing the dangerous action and then displaying a helpful message instead Unrelated to review comments: Remove a useless line of code --- src/dolphinmainwindow.h | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) (limited to 'src/dolphinmainwindow.h') diff --git a/src/dolphinmainwindow.h b/src/dolphinmainwindow.h index 529319e2a..251f50d8d 100644 --- a/src/dolphinmainwindow.h +++ b/src/dolphinmainwindow.h @@ -65,17 +65,19 @@ public: * having a split view setup, the nonactive view * is usually shown in darker colors. */ - DolphinViewContainer* activeViewContainer() const; + DolphinViewContainer *activeViewContainer() const; /** - * Returns view containers for all tabs - * @param includeInactive When true all view containers available in - * this window are returned. When false the - * view containers of split views that are not - * currently active are ignored. - * Default is true. + * Returns the active view containers of all tabs. + * @see activeViewContainer() + * Use viewContainers() to also include the inactive ones. */ - QVector viewContainers(bool includeInactive = true) const; + QVector activeViewContainers() const; + + /** + * Returns all view containers. + */ + QVector viewContainers() const; /** * Opens each directory in \p dirs in a separate tab. If \a splitView is set, -- cgit v1.3