From e2f316578909e4c886430110808d4681997b3cb7 Mon Sep 17 00:00:00 2001 From: Felix Ernst Date: Wed, 26 Jun 2024 12:45:48 +0200 Subject: Revert "DragAndDropHelper::updateDropAction: use StatJob for remote URLs" This reverts commit dc149ec5e52f52c514cf362603d05ba8eea506b8. This prevents a crash. One issue identified is that the commit that I am reverting here accesses a QDropEvent at a moment in time in which it might have already been deleted. We cannot check if it exists by that time because we do not control its lifetime and it is not a QObject. --- src/dolphintabwidget.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/dolphintabwidget.cpp') diff --git a/src/dolphintabwidget.cpp b/src/dolphintabwidget.cpp index 9bfd6076a..f80b94ea7 100644 --- a/src/dolphintabwidget.cpp +++ b/src/dolphintabwidget.cpp @@ -9,6 +9,7 @@ #include "dolphin_generalsettings.h" #include "dolphintabbar.h" #include "dolphinviewcontainer.h" +#include "views/draganddrophelper.h" #include #include @@ -23,7 +24,6 @@ DolphinTabWidget::DolphinTabWidget(DolphinNavigatorsWidgetAction *navigatorsWidget, QWidget *parent) : QTabWidget(parent) - , m_dragAndDropHelper{this} , m_lastViewedTab(nullptr) , m_navigatorsWidget{navigatorsWidget} { @@ -394,7 +394,7 @@ void DolphinTabWidget::tabDragMoveEvent(int index, QDragMoveEvent *event) { if (index >= 0) { DolphinView *view = tabPageAt(index)->activeViewContainer()->view(); - m_dragAndDropHelper.updateDropAction(event, view->url()); + DragAndDropHelper::updateDropAction(event, view->url()); } } -- cgit v1.3