From 8df41dd0061fb92882aefe532bd762341df64072 Mon Sep 17 00:00:00 2001 From: Peter Penz Date: Wed, 26 Sep 2007 11:46:49 +0000 Subject: * Fix memory leak (DolphinCategoryDrawer is leaking...) * There is no need to explicitly turning on the category, as this is done automatically when reading out the view properties. @Rafael: I tested your error description and could not reproduce the problem anymore. If I miss something, please let me know, so that we can work together to fix this :-) CCMAIL: ereslibre@gmail.com svn path=/trunk/KDE/kdebase/apps/; revision=717245 --- src/dolphinview.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'src/dolphinview.cpp') diff --git a/src/dolphinview.cpp b/src/dolphinview.cpp index e0a3df51e..73b44e6fb 100644 --- a/src/dolphinview.cpp +++ b/src/dolphinview.cpp @@ -51,7 +51,6 @@ #include "viewproperties.h" #include "dolphinsettings.h" #include "dolphin_generalsettings.h" -#include "dolphincategorydrawer.h" DolphinView::DolphinView(QWidget* parent, const KUrl& url, @@ -805,25 +804,26 @@ void DolphinView::createView() // ... and recreate it representing the current mode switch (m_mode) { case IconsView: { - const KUrl viewPropsUrl = viewPropertiesUrl(); - const ViewProperties props(viewPropsUrl); - m_iconsView = new DolphinIconsView(this, m_controller); - m_iconsView->setCategoryDrawer(new DolphinCategoryDrawer()); view = m_iconsView; - setCategorizedSorting(props.categorizedSorting()); break; } case DetailsView: m_detailsView = new DolphinDetailsView(this, m_controller); view = m_detailsView; + + // categorized sorting is not supported yet for the details + // view, even if the view properties indicate this setCategorizedSorting(false); break; case ColumnView: m_columnView = new DolphinColumnView(this, m_controller); view = m_columnView; + + // categorized sorting is not supported yet for the column + // view, even if the view properties indicate this setCategorizedSorting(false); break; } -- cgit v1.3