From ad6c01d200e2504de1a383355bd82906fe5c06ed Mon Sep 17 00:00:00 2001 From: David Faure Date: Mon, 26 Mar 2007 18:34:52 +0000 Subject: Using a QLinkedList mostly for "accessing element at index i" is not the best solution performance-wise... use a QList instead. svn path=/trunk/KDE/kdebase/apps/; revision=646813 --- src/dolphinview.cpp | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) (limited to 'src/dolphinview.cpp') diff --git a/src/dolphinview.cpp b/src/dolphinview.cpp index 99757bac7..311ca36b4 100644 --- a/src/dolphinview.cpp +++ b/src/dolphinview.cpp @@ -453,7 +453,7 @@ void DolphinView::setUrlEditable(bool editable) m_urlNavigator->editUrl(editable); } -const QLinkedList DolphinView::urlHistory(int& index) const +const QList DolphinView::urlHistory(int& index) const { return m_urlNavigator->history(index); } @@ -771,15 +771,14 @@ void DolphinView::showPreview(const KFileItem* item, const QPixmap& pixmap) void DolphinView::restoreContentsPos() { int index = 0; - const QLinkedList history = urlHistory(index); + const QList history = urlHistory(index); if (!history.isEmpty()) { QAbstractItemView* view = itemView(); // TODO: view->setCurrentItem(history[index].currentFileName()); - QLinkedList::const_iterator it = history.begin(); - it += index; - view->horizontalScrollBar()->setValue((*it).contentsX()); - view->verticalScrollBar()->setValue((*it).contentsY()); + const UrlNavigator::HistoryElem& it = history[index]; + view->horizontalScrollBar()->setValue(it.contentsX()); + view->verticalScrollBar()->setValue(it.contentsY()); } } -- cgit v1.3