From f32987d719f4b396ea2679b59a712a8bc288b8d2 Mon Sep 17 00:00:00 2001 From: Albert Astals Cid Date: Thu, 24 Apr 2008 20:41:04 +0000 Subject: avoid unnecessary copies by using const & in foreach svn path=/trunk/KDE/kdebase/apps/; revision=800783 --- src/dolphinview.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/dolphinview.cpp') diff --git a/src/dolphinview.cpp b/src/dolphinview.cpp index d87571c7e..28e50a0a2 100644 --- a/src/dolphinview.cpp +++ b/src/dolphinview.cpp @@ -301,7 +301,7 @@ KFileItemList DolphinView::selectedItems() const KFileItemList itemList; const QModelIndexList indexList = selection.indexes(); - foreach (QModelIndex index, indexList) { + foreach (const QModelIndex &index, indexList) { KFileItem item = m_dolphinModel->itemForIndex(index); if (!item.isNull()) { itemList.append(item); @@ -315,7 +315,7 @@ KUrl::List DolphinView::selectedUrls() const { KUrl::List urls; const KFileItemList list = selectedItems(); - foreach (KFileItem item, list) { + foreach (const KFileItem &item, list) { urls.append(item.url()); } return urls; @@ -468,7 +468,7 @@ void DolphinView::setNameFilter(const QString& nameFilter) void DolphinView::calculateItemCount(int& fileCount, int& folderCount) { - foreach (KFileItem item, m_dirLister->items()) { + foreach (const KFileItem &item, m_dirLister->items()) { if (item.isDir()) { ++folderCount; } else { @@ -524,7 +524,7 @@ void DolphinView::renameSelectedItems() // iterate through all selected items and rename them... int index = 1; - foreach (KFileItem item, items) { + foreach (const KFileItem &item, items) { const KUrl& oldUrl = item.url(); QString number; number.setNum(index++); -- cgit v1.3