From c03b43b4a1132ca7bc6db4a1583bc8bd1578b44f Mon Sep 17 00:00:00 2001 From: Ahmad Samir Date: Tue, 15 Dec 2020 00:40:12 +0200 Subject: Use setShowOpenOrExecuteDialog(true) with OpenUrlJob It makes more sense for a file manager to always ask the user: - whether to execute binaries - whether to open an executable script as text or execute it The openOrExecute dialog from KIOWidgets has a "don't ask again" checkbox, and that setting is also accessible from Dolphin's settings dialog. See the discussion at https://bugs.kde.org/show_bug.cgi?id=429839#c10 --- src/dolphinviewcontainer.cpp | 1 - 1 file changed, 1 deletion(-) (limited to 'src/dolphinviewcontainer.cpp') diff --git a/src/dolphinviewcontainer.cpp b/src/dolphinviewcontainer.cpp index 8dd309314..7053c4a6b 100644 --- a/src/dolphinviewcontainer.cpp +++ b/src/dolphinviewcontainer.cpp @@ -638,7 +638,6 @@ void DolphinViewContainer::slotItemActivated(const KFileItem& item) } KIO::OpenUrlJob *job = new KIO::OpenUrlJob(item.targetUrl()); - job->setRunExecutables(true); job->setUiDelegate(new KIO::JobUiDelegate(KJobUiDelegate::AutoHandlingEnabled, this)); job->setShowOpenOrExecuteDialog(true); job->start(); -- cgit v1.3