From 837034490b546beeb7d9a188134a2afb6f2d51b2 Mon Sep 17 00:00:00 2001 From: Egor Maksimov Date: Fri, 6 Mar 2026 09:50:02 +0000 Subject: dolphinviewcontainer: Fix infinite loop in isTopMostParentFolderWritable Certain urls lead to an infinite loop that causes dolphin to halt. Any url that starts with `file:` and the path doesn't have first `/` will lead to this. For example: `file:test` or `file:another/test`. If dolphin somehow saves this state, the program halt right at the start. Rename the function to make its usage less confusing. --- src/dolphinviewcontainer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/dolphinviewcontainer.h') diff --git a/src/dolphinviewcontainer.h b/src/dolphinviewcontainer.h index 8ff1c59e0..3829a4f78 100644 --- a/src/dolphinviewcontainer.h +++ b/src/dolphinviewcontainer.h @@ -466,7 +466,7 @@ private: * Check if a folder can be created at url. * This method supports only local URLs. */ - bool isTopMostParentFolderWritable(QUrl url); + bool isTopMostExistingParentFolderWritable(QUrl url); protected: bool eventFilter(QObject *object, QEvent *event) override; -- cgit v1.3