From b6fc58c3c32b03f504a5f697b62c4834dc3f650a Mon Sep 17 00:00:00 2001 From: Felix Ernst Date: Wed, 12 Aug 2020 20:45:17 +0200 Subject: Adress the first round of Angelaccio's review comments - Split the viewContainers(bool includeInActive) into two methods without parameters - Prevent users from accidently hiding all Url Navigators by preventing the dangerous action and then displaying a helpful message instead Unrelated to review comments: Remove a useless line of code --- src/dolphinviewcontainer.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/dolphinviewcontainer.h') diff --git a/src/dolphinviewcontainer.h b/src/dolphinviewcontainer.h index 822d8072d..77c734949 100644 --- a/src/dolphinviewcontainer.h +++ b/src/dolphinviewcontainer.h @@ -140,8 +140,9 @@ public: /** * Shows the message \msg with the given type non-modal above * the view-content. + * @return the KMessageWidget used to show the message */ - void showMessage(const QString& msg, MessageType type); + KMessageWidget *showMessage(const QString& msg, MessageType type); /** * Refreshes the view container to get synchronized with the (updated) Dolphin settings. -- cgit v1.3