From 1f3607bdc1f9c4c39049079a973d5027187512c2 Mon Sep 17 00:00:00 2001 From: Peter Penz Date: Sun, 29 Jun 2008 21:04:43 +0000 Subject: Move the block for resizing the preview, applying an item effect + border to the slot where the preview has been received. This reduces the blocking of the GUI for the following usecase: - folder with 1000 items - ~30 items are visible Old approach: - Show the 30 items as soon as possible. - Receive preview and add it to the queue. This is done asynchronously 970 times (no UI blocking). - Iterate through 970 items, resize, apply item effect + border and apply the preview to the model (-> blocking of UI thread for more than 3 seconds). New approach: - Show the 30 items as soon as possible. - Receive preview, resize it, apply item effect + border and add it to the queue. This is done asynchronously 970 times (no UI blocking). - Iterate through 970 items and apply the preview to the model (-> UI thread is blocked only very short). svn path=/trunk/KDE/kdebase/apps/; revision=826109 --- src/iconmanager.h | 6 ------ 1 file changed, 6 deletions(-) (limited to 'src/iconmanager.h') diff --git a/src/iconmanager.h b/src/iconmanager.h index 027f0c6b6..06d7df85a 100644 --- a/src/iconmanager.h +++ b/src/iconmanager.h @@ -115,12 +115,6 @@ private slots: void resumePreviews(); private: - /** - * Replaces the icon of the item with the \a url by the preview pixmap - * \a pixmap. - */ - void replaceIcon(const KUrl& url, const QPixmap& pixmap); - /** * Returns true, if the item \a item has been cut into * the clipboard. -- cgit v1.3.1